Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking of plugins url filter hook #312

Merged
merged 6 commits into from
Oct 23, 2013

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Oct 18, 2013

Even though it's common to use a PLUGINNAME_URL constant for creating file paths, the use of this breaks the plugins_url filter.

This pull request replaces all uses of the WPSEO_URL constant with the correct usage of plugins_url()

… file paths, the use of this breaks the plugins_url filter.

This pull request replaces all uses of the WPSEO_URL constant with the correct usage of plugins_url()
@jdevalk
Copy link
Contributor

jdevalk commented Oct 23, 2013

This one looks good too.

jrfnl added a commit that referenced this pull request Oct 23, 2013
…-hook

Fix breaking of plugins url filter hook
@jrfnl jrfnl merged commit dba170e into Yoast:master Oct 23, 2013
@jrfnl jrfnl deleted the Fix-breaking-of-plugins-url-filter-hook branch October 23, 2013 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants