Add early return in the hierachy creation to make sure we don't run a useless query.

[thijsoo]

Context

• After making sure we don't create indexables when the 'Yoast\WP\SEO\should_index_indexables' filter we want to make sure we also disable some side effect filters.

Summary

This PR can be summarized in the following changelog entry:

• Removes unnecessary query when indexables are disabled.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:
Note: Wherever add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); is mentioned, it can also mean that you are on a non-production site instead (aka, have the WP_ENVIRONMENT_TYPE constant indicate a staging or local or development site).

• Make sure you have QM enabled.
• Clear all you indexables and add the following code somewhere in your site:
  add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' );
• Go to any post you have and make sure the following query is not present:

DELETE
FROM `wp_yoast_indexable_hierarchy`
WHERE `indexable_id` = {post_id}`

Remove the filter and make sure you now see the query.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #

[coveralls]

Pull Request Test Coverage Report for Build 42ef26c334130eeda362cb39ea1119f33d599474

Details

• 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
• 836 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.002%) to 52.854%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/builders/indexable-hierarchy-builder.php	3	4	75.0%

Files with Coverage Reduction	New Missed Lines	%
src/generated/container.php	836	0.0%

Totals
Change from base Build a8818d4d5624f16d9f78369aa77336463be0838a:	-0.002%
Covered Lines:	28343
Relevant Lines:	54224

---

💛 - Coveralls

[igorschoester]

CR ✅

[igorschoester]

AC ✅

[coveralls]

Pull Request Test Coverage Report for Build 2c48faf9cd7ff023b978057e296b7eb7f1032a0e

Details

• 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall first build on 21405-when-indexable-creation-is-disabled-theres-redundant-db-queries-on-page-load-in-the-frontend-of-posts at 50.421%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/builders/indexable-hierarchy-builder.php	3	4	75.0%

Totals
Change from base Build aadef3b2c0b385b314d05dc7c56820abc2686e65:	50.4%
Covered Lines:	16035
Relevant Lines:	31802

---

💛 - Coveralls