Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI library custom notification #21406

Draft
wants to merge 74 commits into
base: trunk
Choose a base branch
from

Conversation

pls78
Copy link
Member

@pls78 pls78 commented May 23, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • WIP

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

Jordi-PV and others added 30 commits April 26, 2024 14:32
…ation-ai-buttons-next-to-seo-keyphrase-assessments
…ents' of github.com:Yoast/wordpress-seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
… is used to track whether there is an active AI Fixes button so we can display the button background color and the icon color differently when they are pressed. This is only relevant in Premium. In Free, this logic is irrelevant because clicking on the button will only display the Upsell modal.
FAMarfuaty and others added 24 commits May 13, 2024 10:00
… deactivate the highlighting button and remove the highlighting from the editor
…seo into implementation-ai-buttons-next-to-seo-keyphrase-assessments
…o-seo-keyphrase-assessments

Implementation ai buttons next to seo keyphrase assessments
Copy link

github-actions bot commented May 23, 2024

@pls78 Please be aware that following packages have been abandoned and are not actively maintained anymore:

Package name Path
@yoast/babel-preset packages/babel-preset
@yoast/components packages/components
@yoast/e2e-tests packages/e2e-tests
@yoast/helpers packages/helpers
@yoast/jest-preset packages/jest-preset
@yoast/style-guide packages/style-guide

Please consider using the other packages instead.

@coveralls
Copy link

coveralls commented May 23, 2024

Pull Request Test Coverage Report for Build 9455db39444ece1af78f39ef1a832652d4a1bc81

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 47 of 65 (72.31%) changed or added relevant lines in 14 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 48.345%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/redux/reducers/activeAIButton.js 3 4 75.0%
packages/yoastseo/src/values/AssessmentResult.js 6 7 85.71%
packages/js/src/components/contentAnalysis/Results.js 0 2 0.0%
packages/js/src/components/contentAnalysis/SeoAnalysis.js 0 3 0.0%
packages/js/src/ai-assessment-fixes/components/AIAssessmentFixesButton.js 16 27 59.26%
Files with Coverage Reduction New Missed Lines %
packages/js/src/components/contentAnalysis/SeoAnalysis.js 1 0.0%
packages/js/src/structured-data-blocks/faq/block.js 1 0.0%
packages/js/src/structured-data-blocks/how-to/block.js 1 0.0%
packages/js/src/containers/Results.js 2 0.0%
Totals Coverage Status
Change from base Build 5ccfd2603220c02e5d11fd1608b7ae9f1994dda0: 0.04%
Covered Lines: 25032
Relevant Lines: 53622

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants