Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

192 wc editor create two way sync for the post metadata #21398

Draft
wants to merge 12 commits into
base: feature/woo-new-editor
Choose a base branch
from
Draft

192 wc editor create two way sync for the post metadata #21398

wants to merge 12 commits into from

Conversation

igorschoester
Copy link
Member

Context

Summary

This PR can be summarized in the following changelog entry:

  • Add syncing.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes #

@igorschoester
Add createCollectorFromObject
85f983b 
Already added in PoC and in decouple hidden fields (with tests!!)
There should not be any difference in the code itself
@igorschoester
Add shared constants
e64c914 
Copied from decouple hidden fields branch
Code should be the same
@igorschoester
Use new editor store constant
9583e9f
@igorschoester
Add default metadata the script data
08c9fe6
@igorschoester
Extend the default editor store
946d255 
* adds the ability to extend/override the default editor store
* adds default metadata to the store
* adds primary product metadata to the store
@igorschoester
Add sync from and to metadata
9946418 
* syncs from the WP core edited entity record' metadata to the editor store
* sync from the editor store to the entity record' metadata
* separating getters, setters and transforming as much as possible
@igorschoester
Fix side-effects to not error
e413a1a 
Note: this commit should be removed if the decoupling hidden fields landed
@igorschoester
Fix defaults for advanced settings
68f6c13 
The components set these, and the server side is the same
This prevents the user getting update prompts for no reason
@igorschoester
Add selector for the social image ids
bfd8efe 
* possibly the fallbacks for the IDs should be -1 instead
* fix the facebook url fallback to return an empty string
@igorschoester
Fix postId initial state
4ddf221 
...and JS docs
@igorschoester
Add safety to the primary taxonomies selector
2f21ab8 
...and fix JS doc for the action
@igorschoester
Add overall score selectors for the analyses
7ba27f7
@igorschoester igorschoester added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label May 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build b04fef060e49bb34d12e67b9178365f0e886a7ff

Details

  • 15 of 185 (8.11%) changed or added relevant lines in 25 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 51.977%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/redux/selectors/primaryTaxonomies.js 0 1 0.0%
packages/js/src/woocommerce-editor/store/index.js 0 1 0.0%
packages/js/src/woocommerce-editor/sync/fields.js 0 1 0.0%
packages/js/src/initializers/editor-store.js 0 2 0.0%
packages/js/src/helpers/create-watcher.js 0 3 0.0%
packages/js/src/woocommerce-editor/initialize.js 0 3 0.0%
src/woocommerce-editor/framework/woocommerce-editor-script-data.php 0 3 0.0%
packages/js/src/woocommerce-editor/store/primary-term.js 0 4 0.0%
packages/js/src/helpers/fields/SearchMetadataFields.js 0 6 0.0%
packages/js/src/woocommerce-editor/sync/index.js 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
packages/js/src/woocommerce-editor/initialize.js 1 0.0%
Totals Coverage Status
Change from base Build c65fca879868c0237fd29007a9c1a8b04621335e: -0.2%
Covered Lines: 28741
Relevant Lines: 55766
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igorschoester @coveralls