Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Yarn 4 #21345

Draft
wants to merge 50 commits into
base: trunk
Choose a base branch
from
Draft

Upgrade to Yarn 4 #21345

wants to merge 50 commits into from

Commits on Apr 26, 2024

  1. Configuration menu
    Copy the full SHA
    c2164c9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c3035b View commit details
    Browse the repository at this point in the history
  3. Remove yoast-components

    igorschoester committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    f685e61 View commit details
    Browse the repository at this point in the history
  4. Add Yarn 4

    igorschoester committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    39159af View commit details
    Browse the repository at this point in the history
  5. Safe fix .gitignore

    igorschoester committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    eabf07c View commit details
    Browse the repository at this point in the history
  6. Fix grunt clean

    igorschoester committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    98eea7f View commit details
    Browse the repository at this point in the history
  7. Refactor pretest to be part of test itself

    Yarn 4 removed pre- and post- lifecycle scripts: https://yarnpkg.com/advanced/lifecycle-scripts
    igorschoester committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7742ddf View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Remove prepublishOnly in favor of files

    * remove side-effect of publish, as per the recommendation in https://yarnpkg.com/advanced/lifecycle-scripts
    * using files determine what we would publish, see https://docs.npmjs.com/cli/v10/configuring-npm/package-json#files
    * ignore .map files, just in case the build contains them
    * move browserslist-config index out of `src` folder, just for convenience of no `src` in the published version
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    25ca4ed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0706cbe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a824ac0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2783c21 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3621d7a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8789e15 View commit details
    Browse the repository at this point in the history
  7. Fix @yoast/wordpress-seo build and test commands

    Tweak lint to use .eslintignore file instead of only running in the src and tests folders
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    a07032c View commit details
    Browse the repository at this point in the history
  8. Fix @yoast/replacement-variable-editor test

    Move lint ignore to separate file
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c1c444a View commit details
    Browse the repository at this point in the history
  9. Fix @yoast/search-metadata-previews test

    * upgrade @wordpress/components to WP 6.4 version, fixes a test failing on UUID sub dependency having require
    * move lint ignore to separate file
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ea9c2af View commit details
    Browse the repository at this point in the history
  10. Fix @yoast/social-metadata-forms lint and test

    * add own config
    * auto-fix comma-dangle
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    39e0dba View commit details
    Browse the repository at this point in the history
  11. Fix @yoast/social-metadata-previews lint and test

    * add own config
    * auto-fix comma-dangle
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0223d5b View commit details
    Browse the repository at this point in the history
  12. Change @yoast/ui-library scripts

    * rename clean:build to clean, inline with the other packages
    * prefix node commands with yarn, as per their recommendedation when using PnP linking mode: https://yarnpkg.com/migration/pnp#enabling-yarn-pnp
    * switch to lint all vs just src (ignore missing test deps)
    * add missing jest jsdom, even though tests are disabled
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    750a434 View commit details
    Browse the repository at this point in the history
  13. Expand yoastseo lint

    * introducing ignore file
    * tune the max warnings to the current number
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    62c2799 View commit details
    Browse the repository at this point in the history
  14. Fix root tooling lint

    * move to JS format
    * remove exceptions
    * change react to detect
    * add css/dist/ to ignore list
    * auto-fix comma-dangle
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    d1cbf84 View commit details
    Browse the repository at this point in the history
  15. Upgrade jest and cohorts

    * starting with the upgrade in our jest-preset
    * upgrade the other packages to match
    * fixes needed, coming in next commits
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    e0a6a41 View commit details
    Browse the repository at this point in the history
  16. Update snapshots

    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    ded88a6 View commit details
    Browse the repository at this point in the history
  17. Fix indexation component

    * an error would result in an infinite loop: add url = false
    * an error would not result in the error being displayed: add wait for next cycle
    * the above fixes the indexation tests
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0f297fb View commit details
    Browse the repository at this point in the history
  18. Fix search test warning

    * missing act
    * the closing would result in further state changes that were not captured by the fireEvent.click
    * solution: wrap next check in waitFor
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    daca422 View commit details
    Browse the repository at this point in the history
  19. Clean Jest config

    * remove the UI library source from the module mapping, it is expected to run build before test instead
    * remove different node_module overrides
    * add WP i18n to the module mapping to ensure a singleton, this fixes the text-domain warnings
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2159a0f View commit details
    Browse the repository at this point in the history
  20. Specify lerna/nx task dependencies

    * see https://lerna.js.org/docs/concepts/task-pipeline-configuration
    * upgrade lerna
    * ran lerna repair
    * specify ignore cache in grunt tasks, just to ensure no change there
    * add clean task (handy for cache busting too)
    * alphabetize scripts
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    96185d9 View commit details
    Browse the repository at this point in the history
  21. Upgrade babel preset and cohorts

    * skipping preset upgrades - lets not require minor upgrades
    * feature-flag: remove unused babel plugins
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    a61cfd5 View commit details
    Browse the repository at this point in the history
  22. Bump CSS deps

    * align versions
    * fix missing tailwindcss in root
    * fix wrong tailwindcss/forms version (not as per postcss-preset requirement)
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2b32305 View commit details
    Browse the repository at this point in the history
  23. Fix webpack deps

    * remove unused from JS
    * add missing webpack peer dep to UI lib
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    10c80db View commit details
    Browse the repository at this point in the history
  24. Fix style-guide deps

    * move to actual deps: @yoast/helpers and styled-components
    * remove unused json dep
    * add peer deps: react and react-dom
    * add browserslist config to extend the yoast config
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    2d813f6 View commit details
    Browse the repository at this point in the history
  25. Upgrade redux

    * @reduxjs/toolkit requires react-redux 7 or 8
    * react-redux 8 requires redux 4
    * remove redux-thunk and unused script that was using it
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    cb6f33f View commit details
    Browse the repository at this point in the history
  26. Fix react deps

    * add react and react-dom to root, to satisfy peer deps
    * remove unused @testing-library/react-hooks, warned about wanting older version of react-renderer (16.9.0 or 17.0.0 vs actual 18.2.0)
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    6bfff26 View commit details
    Browse the repository at this point in the history
  27. Add missing draft-js peer deps from replacement-variable-editor

    * as peer deps of the packages using replacement-variable-editor
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    71e025f View commit details
    Browse the repository at this point in the history
  28. Add Grunt dev dep

    * required by grunt-contrib-clean, grunt-shell and grunt-git
    * update grunt-git to work with grunt 1.6.1
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    7cac804 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    bd01cc3 View commit details
    Browse the repository at this point in the history
  30. Fix yarn start

    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    c7ddb8e View commit details
    Browse the repository at this point in the history
  31. Upgrade react-modal

    * because it supports React 18
    * turns out the close on click outside error is fixed too:
    * removing shouldCloseOnClickOutside false for: SearchAppearanceModal, SocialAppearanceModal, SEMrushRelatedKeyphrasesModal, WincherSEOPerformanceModal (Elementor) and InsightsModal (Elementor)
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    20873ad View commit details
    Browse the repository at this point in the history
  32. Remove unused react-intl and IntlProvider

    * not using React 18 (but 16 at the latest)
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    9f639ed View commit details
    Browse the repository at this point in the history
  33. Remove react-aria-live

    * inactive package since 5 years
    * still requiring React 16.3.x
    * moving over to already used WP a11y' speak
    * adding a hook and wrapper component for ease of use, as per downside of original PR: #19615
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    247b79c View commit details
    Browse the repository at this point in the history
  34. Upgrade WP blocks to WP 6.4 version

    * due to warning about React 18 (package was using 17 before)
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    551d6ff View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    a02c035 View commit details
    Browse the repository at this point in the history
  36. Upgrade UI lib WP jest-preset-default

    * was requiring old React version (via react-test-renderer)
    * not really used at the moment
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    545d333 View commit details
    Browse the repository at this point in the history
  37. Upgrade WP packages to their WP 6.4 version

    (or packages provided by WP)
    * trigger was some requiring older React version -- not totally solved yet:
      * WP components at WP 6.5 version will solve Reakit
      * WP block-editor still requires react-autosize-textarea, which is archived since March 1, 2024
      * WP compose and WP data still use use-memo-one 1.1.2 or 1.1.1 where 1.1.3 has React 18 support
    * we are not providing these packages in our plugin, so this is only affecting testing and development
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    a73036d View commit details
    Browse the repository at this point in the history
  38. Clean jest-preset and configs

    * no more transform ignore or mapping of Yoast packages or lodash-es
    * remove unused find-with-regex
    * fix test import of lodash-es to use lodash
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    7eb8584 View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    078a810 View commit details
    Browse the repository at this point in the history
  40. Switch react and react-dom to actual deps

    * they are required as peer deps by @yoast/style-guide now
    * and it makes a bit more sense that it is actually used, even though it is mostly indirectly via WP element
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    88657cf View commit details
    Browse the repository at this point in the history
  41. Add missing dev deps for Grunt

    * using versions from @yoast/grunt-plugin-tasks range to prevent potential problems
    * fixing version of @yoast/grunt-plugin-tasks
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    499e67b View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    b10abb5 View commit details
    Browse the repository at this point in the history
  43. Remove jest version output from CI

    There are no tests in the root folder
    igorschoester committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    437a80c View commit details
    Browse the repository at this point in the history