Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent fatals with the Howto block in rare situations #21332

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from
+3 −3
Open

Prevent fatals with the Howto block in rare situations #21332

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1d4346b
Check for numeric and always cast to int
Djennez Apr 23, 2024
1bc3441
Check for numeric and always cast to float
Djennez Apr 23, 2024
9cbac04
Back to intval, since we dont accept floats anyway
Djennez Apr 23, 2024
76d8f8f
CS
Djennez Apr 23, 2024
f1f0860
Simplify and prevent warnings
Djennez May 7, 2024
2966359
CS
Djennez May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Next Next commit
Check for numeric and always cast to int
  • Loading branch information
@Djennez
Djennez committed Apr 23, 2024
commit 1d4346bcf6665dcb81031f2fc9e476814a92af2b
6 changes: 3 additions & 3 deletions src/generators/schema/howto.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ private function add_duration( &$data, $attributes ) {
return;
}

$days = empty( $attributes['days'] ) ? 0 : $attributes['days'];
$hours = empty( $attributes['hours'] ) ? 0 : $attributes['hours'];
$minutes = empty( $attributes['minutes'] ) ? 0 : $attributes['minutes'];
$days = ! is_numeric( $attributes['days'] ) ? 0 : intval( $attributes['days'] );
$hours = ! is_numeric( $attributes['hours'] ) ? 0 : intval( $attributes['hours'] );
$minutes = ! is_numeric( $attributes['minutes'] ) ? 0 : intval( $attributes['minutes'] );

if ( ( $days + $hours + $minutes ) > 0 ) {
$data['totalTime'] = \esc_attr( 'P' . $days . 'DT' . $hours . 'H' . $minutes . 'M' );
Expand Down