Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

21141 decouple hidden fields for metabox #21161

Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
352 commits
Select commit Hold shift + click to select a range
ca254e2
add defensive coding to ensure string
vraja-pro Mar 6, 2024
92b2b95
moves constants to shared-admin folder
vraja-pro Mar 7, 2024
73c7e2b
rename constants for stores name
vraja-pro Mar 7, 2024
f763e60
rename constant for post metadata keys
vraja-pro Mar 7, 2024
40606a4
fix constants and added defensive coding for primary term id function
vraja-pro Mar 7, 2024
febbd59
fix store name and import
vraja-pro Mar 7, 2024
3c4d040
use defaultTo
vraja-pro Mar 7, 2024
d33f6c7
Add defensive coding to analysis scores
vraja-pro Mar 7, 2024
c1858ee
add defensive coding to reading time
vraja-pro Mar 7, 2024
7a766a6
add defensive coding and move reading time to analysis file
vraja-pro Mar 7, 2024
15bd734
add defensive coding to primary term id
vraja-pro Mar 7, 2024
d53069a
Add defensive coding to opengraph fields
vraja-pro Mar 7, 2024
ffafab7
Add defensive coding to schema fields
vraja-pro Mar 7, 2024
4ce2822
add defensive coding for snippet editor fields
vraja-pro Mar 7, 2024
011378d
add defensive coding to twitter fields
vraja-pro Mar 7, 2024
a0b6e38
fix js docs comments
vraja-pro Mar 7, 2024
410dae9
fix type for hidden fields sync function
vraja-pro Mar 7, 2024
8a13f6c
fix type comment
vraja-pro Mar 7, 2024
4236a9f
fix array type comments
vraja-pro Mar 7, 2024
0b30a3c
fix array type comment
vraja-pro Mar 7, 2024
d6b76f2
remove to string rom twitter id, handled in twitter fields store file
vraja-pro Mar 7, 2024
de68a22
Listen to the original field like in classic editor, and not the hidd…
vraja-pro Mar 8, 2024
6cca4f4
remove check for metabox container and check for metadata in window o…
vraja-pro Mar 8, 2024
a3d34df
restore side effect with defensive coding
vraja-pro Mar 8, 2024
6991c8b
cleanup sync of primary category
vraja-pro Mar 8, 2024
36726de
no need for estimate reading time class and conditional. the field is…
vraja-pro Mar 8, 2024
5849a01
simplify adding primery term to be registered as metadata
vraja-pro Mar 8, 2024
30b84dc
we want to listen to the metadata even when there is no value
vraja-pro Mar 8, 2024
4ff3efc
if there is no primary term, return an empty string
vraja-pro Mar 8, 2024
50c94cc
zero and empty string are saved the same, with empty string we avoid …
vraja-pro Mar 8, 2024
0d3234d
cleanup estimate reading time tests
vraja-pro Mar 8, 2024
4b70f09
wordproof metadata is not registered by that filter
vraja-pro Mar 11, 2024
ee282b9
register metadata
vraja-pro Mar 11, 2024
6731e7d
Hidden is not translation
vraja-pro Mar 11, 2024
69579db
php fix-cs
vraja-pro Mar 11, 2024
9c5dede
remove tests from removed class
vraja-pro Mar 11, 2024
bb67ad2
no need to trigger change on the hidden field.
vraja-pro Mar 11, 2024
b52f05c
initial editor store the same way in elementor, added also comments
vraja-pro Mar 11, 2024
1912305
used WPSEO_Taxonomy_Meta for getting term meta
vraja-pro Mar 11, 2024
b19aed0
// Score is updated to the hidden field though the sync function.
vraja-pro Mar 11, 2024
47f6a81
register metadata wordproof in an initialiser
vraja-pro Mar 12, 2024
e43b3df
get term metadata with wpseo taxonomy meta class
vraja-pro Mar 12, 2024
442a63d
restore to match the hidden fields
vraja-pro Mar 12, 2024
8757d06
The default is true in WPSEO_Option_Social
vraja-pro Mar 18, 2024
bab7f5d
reverting name change
vraja-pro Mar 18, 2024
fc46bdb
Check if hidden fields are present before adding syncing
vraja-pro Mar 18, 2024
65115e8
restore naming
vraja-pro Mar 18, 2024
cc2cd14
Add initial states for social appearance
vraja-pro Mar 19, 2024
21c2338
adds initial state to the elementor editor
vraja-pro Mar 19, 2024
a6d9f5f
remove load from twitter reducer
vraja-pro Mar 19, 2024
4ccf7fe
add sync to term edit
vraja-pro Mar 19, 2024
5d79d63
add support for elementor
vraja-pro Mar 19, 2024
246bf34
cleanup tests from old code
vraja-pro Mar 19, 2024
7da3833
cleanup old code from tests
vraja-pro Mar 19, 2024
5aa0b01
cleanup tests
vraja-pro Mar 20, 2024
f02f904
Add tests to social appearance methods to get values from store to be…
vraja-pro Mar 20, 2024
49d5f7b
Check the right values are used for sync
vraja-pro Mar 20, 2024
026696e
fix tests comments
vraja-pro Mar 20, 2024
9815397
fix advanced settings loading and add tests
vraja-pro Mar 20, 2024
25fa048
fix wordproof conditional
vraja-pro Mar 21, 2024
7896507
add initial state for analysis fields
vraja-pro Mar 21, 2024
18328d7
no need for onload function when we have initial state
vraja-pro Mar 21, 2024
bea6f2a
Added tests to analysisFieldsStore.js
vraja-pro Mar 26, 2024
9ece15f
fix tests
vraja-pro Mar 26, 2024
78ffe67
rename initial state folder and fixed prepareValue
vraja-pro Mar 26, 2024
dae0866
seo analysis is being calculated onload
vraja-pro Mar 26, 2024
822b5ec
remove analysis from initial state
vraja-pro Mar 26, 2024
694cd87
add initial state to primary term
vraja-pro Mar 26, 2024
5dd5f3b
add tests to getPrimaryTerms and refactor getPrimaryTerms
vraja-pro Mar 27, 2024
0239878
schema initial state and cleanup
vraja-pro Mar 27, 2024
8b1e377
Add schema to test cases
vraja-pro Mar 27, 2024
f6ba85f
reduce wait time in sync
vraja-pro Mar 28, 2024
d32d6bc
refreshing app through the subscribe for the focus keyphrase and snip…
vraja-pro Mar 28, 2024
2fd0808
added tests to functions in create-watcher.js
vraja-pro Mar 28, 2024
aec9a62
Add tests to the hidden fields sync
vraja-pro Mar 28, 2024
0c91389
Hide type null from rest
vraja-pro Apr 5, 2024
3fa3948
refactor for better reading
vraja-pro Apr 5, 2024
957322d
Merge remote-tracking branch 'origin/trunk' into 21141-decouple-hidde…
vraja-pro Apr 5, 2024
b649c75
Merge remote-tracking branch 'origin/trunk' into 21141-decouple-hidde…
vraja-pro Apr 8, 2024
119f47c
remove values from hidden fields. That would be populated by the hidd…
vraja-pro Apr 9, 2024
d562bcd
Check also for hidden fields in elementor
vraja-pro Apr 9, 2024
a6aeac1
check for hidden fields in default before check for elementor
vraja-pro Apr 9, 2024
b8eec47
Add auth call back to metadata
vraja-pro Apr 9, 2024
a8b8cae
hidden fields would be synced automatically
vraja-pro Apr 9, 2024
e4031e8
check if we shouls show article type input
vraja-pro Apr 9, 2024
147ebe3
php fix cs
vraja-pro Apr 9, 2024
b683ff7
now that we are registering the metadata, we are using type check and…
vraja-pro Apr 9, 2024
d1e5d94
php fix-cs
vraja-pro Apr 9, 2024
dcd8fd5
php fix cs
vraja-pro Apr 9, 2024
4ecf1aa
fix tests for taxonomy fields presenter
vraja-pro Apr 9, 2024
77288be
Update packages/js/src/elementor.js
vraja-pro Apr 9, 2024
edcb22d
remove default because we are not using it
vraja-pro Apr 9, 2024
728d7df
change the export and import of create watcher
vraja-pro Apr 9, 2024
ec176bd
Merge branch '21141-decouple-hidden-fields-for-metabox' of https://gi…
vraja-pro Apr 9, 2024
c71ffe7
fix js tests for hidden fields sync
vraja-pro Apr 10, 2024
dd96a06
remove unused prop types checks
vraja-pro Apr 10, 2024
2ee2774
fix create watcher import
vraja-pro Apr 10, 2024
4821f1b
fix Jsdoc comment
vraja-pro Apr 10, 2024
9cb62a9
fix import of create watcher
vraja-pro Apr 10, 2024
1d93ca4
cleanup tests
vraja-pro Apr 10, 2024
9cc70e1
restore social option fallback
vraja-pro Apr 10, 2024
008daa3
fix php type comment
vraja-pro Apr 10, 2024
e53fa38
rename method
vraja-pro Apr 10, 2024
e919e2e
fix defensive coding
vraja-pro Apr 10, 2024
57bedd1
Merge remote-tracking branch 'origin/trunk' into 21141-decouple-hidde…
vraja-pro Apr 10, 2024
11129a9
check we have meta in current post
vraja-pro Apr 10, 2024
24580dc
I will use createCollectorFromObject in the addons
vraja-pro Apr 10, 2024
809affb
refactor check for hidden fields
vraja-pro Apr 10, 2024
7c03aee
add_extra_wpseo_meta_fields should be used in an initialiser
vraja-pro Apr 11, 2024
8e91286
fix mapping of metadata keys
vraja-pro Apr 11, 2024
8eaa0de
hide metadata from users that don't have edit post capabilities
vraja-pro Apr 12, 2024
4dab37a
php fix-cs
vraja-pro Apr 12, 2024
4b7d119
Merge remote-tracking branch 'origin/trunk' into 21141-decouple-hidde…
vraja-pro Apr 12, 2024
704dbad
decreased cs threshold
vraja-pro Apr 12, 2024
cefc54f
fix prefix for terms
vraja-pro Apr 12, 2024
9e55cf9
fix js tests
vraja-pro Apr 12, 2024
76f8292
replace prepare callback with schema context
vraja-pro Apr 15, 2024
26cde70
schema defaults are not metadata. Moved them to a separate window obj…
vraja-pro Apr 15, 2024
9b0e57c
remove variable
vraja-pro Apr 15, 2024
935a988
moving schema defaults to post metabox formatter
vraja-pro Apr 15, 2024
ba45ea0
Merge branch 'trunk' into 21141-decouple-hidden-fields-for-metabox
vraja-pro Apr 16, 2024
689ad1c
rename constants
vraja-pro Apr 17, 2024
f904961
remove default to since it is done in the selectors
vraja-pro Apr 17, 2024
54ef032
refactor hidden fields sync and constants
vraja-pro Apr 19, 2024
eda57cd
refactor postId selector and added a selector if it's a post
vraja-pro Apr 19, 2024
fd45e25
rename selector import
vraja-pro Apr 22, 2024
7011d8e
Update admin/class-primary-term-admin.php
vraja-pro Apr 22, 2024
ad58981
fix param comment
vraja-pro Apr 22, 2024
9c6f340
fix param comment
vraja-pro Apr 22, 2024
e7af60e
fix comments for return type
vraja-pro Apr 22, 2024
f7857b8
removed the value from the primary taxonomy field, would be populated…
vraja-pro Apr 22, 2024
adac20b
Merge remote-tracking branch 'origin/trunk' into 21141-decouple-hidde…
vraja-pro Apr 22, 2024
6c23bd7
cleanup duplication of code
vraja-pro Apr 22, 2024
81ff1b4
primary taxonomies are already part of the window object
vraja-pro Apr 22, 2024
62864b4
get primary terms from the right window object and add get check
vraja-pro Apr 22, 2024
c11a433
changed post reducer
vraja-pro Apr 22, 2024
cd9be89
fix primary term initial state default
vraja-pro Apr 22, 2024
8d35eca
restore selectors
vraja-pro Apr 22, 2024
b793070
convert to string the taxonomy id
vraja-pro Apr 22, 2024
19ac603
Update inc/class-wpseo-meta.php
vraja-pro Apr 22, 2024
9cc93b2
changing visibility to private
vraja-pro Apr 22, 2024
bf9e8d5
fix param type comment
vraja-pro Apr 22, 2024
e99cb9c
php fix-cs
vraja-pro Apr 22, 2024
4370e8e
php cs fix
vraja-pro Apr 22, 2024
6d0dc01
php fix cs
vraja-pro Apr 23, 2024
090bab8
fix php cs threshold
vraja-pro Apr 23, 2024
68c7346
fix js tests
vraja-pro Apr 23, 2024
ae39ad4
cleanup side effect from primary taxonomy picker
vraja-pro Apr 23, 2024
1ddd210
add the comment from the post scrapper
vraja-pro Apr 23, 2024
9e9a10c
add sync to meta description and title
vraja-pro Apr 23, 2024
ff08611
removed "yoast_wpseo_metadesc", because it's hidden field. I added a …
vraja-pro Apr 23, 2024
63830a6
add sanitization for primary terms, wordproof time stamp and estimate…
vraja-pro Apr 23, 2024
1bc3a1a
add sanitization to other values that are numerical
vraja-pro Apr 24, 2024
f7f246e
add metadata group class
vraja-pro Apr 24, 2024
71f977f
update thresholds
vraja-pro Apr 24, 2024
af660e2
no other logic should be in the construct
vraja-pro Apr 24, 2024
4f09461
removed class without tests
vraja-pro Apr 24, 2024
78901b6
fix thresholds
vraja-pro Apr 24, 2024
e5f3536
use metadata groups class in elementor
vraja-pro Apr 24, 2024
46b8997
refined the sanitisation of id's to be more precise
vraja-pro Apr 24, 2024
f33dcd3
refactor mapping and added initial state
vraja-pro Apr 26, 2024
438c89c
fix tests and primary taxonomy getters method
vraja-pro Apr 26, 2024
85c0cdc
fix js eslint errors
vraja-pro Apr 26, 2024
67437d9
fix js eslint
vraja-pro Apr 26, 2024
6e1afb0
eslint fix cs
vraja-pro Apr 26, 2024
f17786d
fix php test
vraja-pro Apr 26, 2024
6bf99e2
fix eslint
vraja-pro Apr 26, 2024
0732a1c
fix php cs
vraja-pro Apr 26, 2024
dbb1985
refactor transforming values before comparing
vraja-pro Apr 26, 2024
0638706
restore primary term to avoid trigger of unsaved values
vraja-pro Apr 26, 2024
9fd2b02
fix comparing values in blockeditor sync
vraja-pro Apr 26, 2024
eaf30bf
Add defaults
vraja-pro Apr 29, 2024
5a5f4b3
add slug to window object and initial state
vraja-pro Apr 29, 2024
730bd9d
make sure post ID is the same in post and term
vraja-pro Apr 30, 2024
7321f50
change type in the method comment
vraja-pro Apr 30, 2024
0f73989
restore integer primary id after adding case for sanitazing meta data…
vraja-pro Apr 30, 2024
41d6c67
Update admin/class-primary-term-admin.php
vraja-pro May 2, 2024
7c5ba0f
Update admin/class-primary-term-admin.php
vraja-pro May 2, 2024
9447178
Update admin/class-primary-term-admin.php
vraja-pro May 2, 2024
0f4a61b
Update admin/class-primary-term-admin.php
vraja-pro May 2, 2024
42eb185
Update admin/class-primary-term-admin.php
vraja-pro May 2, 2024
722e6ca
fix type annotation
vraja-pro May 2, 2024
e841d98
Update inc/class-wpseo-primary-term.php
vraja-pro May 2, 2024
8cfe4f8
restore the array type annotation to reduce testing scope and typo mi…
vraja-pro May 2, 2024
a554778
fix spaces
vraja-pro May 2, 2024
83a99ea
use di container
vraja-pro May 2, 2024
cd85330
add comment for entity type
vraja-pro May 3, 2024
0aa4c63
fix slug initial state
vraja-pro May 3, 2024
b054061
bail when getData is not a function, defensive coding
vraja-pro May 3, 2024
c80b7bb
fix sync of slug to hidden fields
vraja-pro May 3, 2024
057ec64
restore the usage of snippet editor slug selector
vraja-pro May 3, 2024
b12a2c4
sync seo description in term editor
vraja-pro May 3, 2024
a6f04b1
fix snippet editor slug in term editor
vraja-pro May 3, 2024
3d195c6
remove import
vraja-pro May 3, 2024
2d63760
remove complexity disable comment
vraja-pro May 3, 2024
3564749
I removed the slug case because sync is taken take of by the hidden f…
vraja-pro May 3, 2024
513f641
add space
vraja-pro May 3, 2024
c727844
Update packages/js/src/helpers/fields/blockEditorSync.js
vraja-pro May 6, 2024
27ae693
Update packages/js/src/helpers/fields/hiddenFieldsSync.js
vraja-pro May 6, 2024
507b9f9
remove the function check
vraja-pro May 6, 2024
88821e0
don't show in rest if type is null
vraja-pro May 6, 2024
82f243a
rename show article type action and property in the store
vraja-pro May 6, 2024
1a59d75
check get in a function in store
vraja-pro May 6, 2024
8adfbb1
more processes to the create updater to be used once
vraja-pro May 6, 2024
20d1d45
fix callback function
vraja-pro May 6, 2024
ab7e918
add taxonomies from the store and use it
vraja-pro May 6, 2024
3789c15
refactor transform data
vraja-pro May 6, 2024
3b0a2ae
Add comment for IDE
vraja-pro May 7, 2024
6a1f9e5
refactor get primary taxonomies and ad selector
vraja-pro May 7, 2024
2b721c1
refactor post actions and reducer
vraja-pro May 7, 2024
78d2331
change initial state import
vraja-pro May 7, 2024
e2db89a
fix indentation
vraja-pro May 7, 2024
5740f32
prepare seo and social appearance with replacement variables
vraja-pro May 7, 2024
8da5062
use metadata groups class via constructor
vraja-pro May 7, 2024
af8b26d
change callback function to static
vraja-pro May 7, 2024
c4faf62
check for metadata from getEditedEntityRecord
vraja-pro May 7, 2024
3e14aa1
use constants for core store
vraja-pro May 7, 2024
1ddbfa9
restore thresholds
vraja-pro May 7, 2024
dfab9c8
fix primary terms tests
vraja-pro May 7, 2024
9362e22
deprecate estimate reading time classes
vraja-pro May 8, 2024
7f1cd89
fix object annotation
vraja-pro May 8, 2024
14a2f7e
execute getCurrentPost in the return
vraja-pro May 8, 2024
ee04d6c
fix transform meta value
vraja-pro May 8, 2024
dbb6c8d
fix php cs
vraja-pro May 9, 2024
dbb579f
restore and deprecate estimate reading time
vraja-pro May 10, 2024
7596d20
deprecate estimate reading time
vraja-pro May 10, 2024
09f3a93
restore thresholds and remove duplicate conditional
vraja-pro May 10, 2024
fe58c16
remove estimate reading time tests
vraja-pro May 10, 2024
84bdbc8
remove new estimate reading time
vraja-pro May 10, 2024
9019697
update cs thresholds
vraja-pro May 13, 2024
2dd6952
restore postId in the store
vraja-pro May 13, 2024
2e13f10
no need to transform the data form the core editor store
vraja-pro May 13, 2024
6ab98a2
dont transform if there is no field and use existing action is it's a…
vraja-pro May 13, 2024
a1b63b0
update tests
vraja-pro May 13, 2024
cd8b98b
fix transform for social and google title and description
vraja-pro May 13, 2024
e40ef9d
fix comment in transform method
vraja-pro May 13, 2024
e6b42ad
fix eslint
vraja-pro May 13, 2024
329f15f
fix term meta description getter
vraja-pro May 13, 2024
ac6a4c9
Remove conditional to avoid errors
vraja-pro May 14, 2024
e1de48f
restore estimated reading time to the wpseo meta fields
vraja-pro May 14, 2024
4116db5
refactor comments and naming for social title and description selectors
vraja-pro May 14, 2024
1ec0763
fix js docs
vraja-pro May 14, 2024
c5f7b29
fix annotation
vraja-pro May 15, 2024
fcb7516
Merge branch 'feature/decouple-hidden-fields' into 21141-decouple-hid…
vraja-pro May 15, 2024
9f286df
fix thresholds after merge
vraja-pro May 15, 2024
27257e6
fix transform meta for image ids
vraja-pro May 15, 2024
9e5cbd0
fix typo
vraja-pro May 15, 2024
a80fb3d
fix no index for term
vraja-pro May 15, 2024
9da1bcc
add leading to the sync
vraja-pro May 16, 2024
76702b7
fix seo score getter
vraja-pro May 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
seo analysis is being calculated onload
  • Loading branch information
vraja-pro committed Mar 28, 2024
commit dae0866e2528d19f6753431e6ff213d9dab7c88d
24 changes: 0 additions & 24 deletions packages/js/src/redux/initial-state/analysis.js

This file was deleted.

1 change: 1 addition & 0 deletions packages/js/src/redux/initial-state/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import get from "lodash/get";
import { facebookInitialState, twitterInitialState } from "./socialAppearance";
import { advancedSettingsInitialState } from "./advancedSettings";
export * from "./socialAppearance";
import analysis from "./analysis";

const initialState = {
facebookEditor: facebookInitialState,
Expand Down