-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update toolings and dependencies in yoastseo package #20651
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with some unnecessary files
…hing works yet, but almost there
…es that already have tests
Pull Request Test Coverage Report for Build 7a2ab1b4f91c508c2ff4a90ffffb29ba5b83d461Details
💛 - Coveralls |
…yoast/wordpress-seo" package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog: non-user-facing
Needs to be included in the 'Non-userfacing' category in the changelog
Shopify
This PR impacts Shopify.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
yoastseo
package.yoastseo
package.import/no-unresolved
ESLint rule when importing fromyoastseo
package.Relevant technical choices:
yoastseo
package was moved to the.eslintrc.js
inside the package@yoast/wordpress-seo
and@yoast/search-metadata-previews
package so that we ignoreimport/no-unresolved
rule when importing fromyoastseo
packagegrunt
anymore, except for retrieving the premium configuration which will be tackled in a separate PR in the futureTest instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
For acceptance testing for the developer
yarn test
yarn lint
Test in Free
Test in the add-ons (Premium, Local SEO, Video SEO, WooCommerce SEO, News SEO)
trunk
and make sure to runcomposer require
commandTest in Shopify
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes #