Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Killer intro project #19884

Draft
wants to merge 17 commits into
base: trunk
Choose a base branch
from
+205 −0
Draft

Killer intro project #19884

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5a666fb
adding an assessment for a killer intro
marinakoleva Feb 16, 2023
c9d3d60
exposing the assessment
marinakoleva Feb 16, 2023
23ec367
adding scores to assessment
marinakoleva Feb 16, 2023
a4b4096
console logs
marinakoleva Feb 16, 2023
d9f0b6d
trying to debug
marinakoleva Feb 16, 2023
6bb37fc
extending the slice function to include one more sentence
marinakoleva Feb 16, 2023
486fa14
remove unneeded entries from default config
hdvos Feb 16, 2023
c1e61d3
allow for config argument again.
hdvos Feb 16, 2023
15a6b27
remove console logs
hdvos Feb 16, 2023
0b71a21
remove checkForTooLongSentences from imports
hdvos Feb 16, 2023
7c013e9
change max allowed sentence length
hdvos Feb 16, 2023
70a2b54
remove console log from checkForTooLongSentences
hdvos Feb 16, 2023
01418ac
change feedback string for good result
hdvos Feb 16, 2023
b05f6c9
implement paragraph assessment.
hdvos Feb 16, 2023
0e72251
rename recommendedLength to recommendedParagraphLength
hdvos Feb 16, 2023
0d691aa
fix donkey mistake
hdvos Feb 16, 2023
99b4c31
correctly get first two paragraphs
hdvos Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove checkForTooLongSentences from imports
  • Loading branch information
@hdvos
hdvos committed Feb 16, 2023
commit 0b71a210af74dda2d612e2127e1af072745e239f
1 change: 0 additions & 1 deletion packages/yoastseo/src/scoring/assessments/readability/IntroQualityCheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import { createAnchorOpeningTag } from "../../../helpers";
import AssessmentResult from "../../../values/AssessmentResult";
import { merge } from "lodash-es";
import { getSentences } from "../../../languageProcessing";
import checkForTooLongSentences from "../../helpers/assessments/checkForTooLongSentences";
import getWords from "../../../languageProcessing/helpers/word/getWords.js";
/**
* Represents the assessment that will look if the text has a list (only applicable for product pages).
Expand Down