Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow settings integration on free, change logic for conditionals #18964

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

jdevalk
Copy link
Contributor

@jdevalk jdevalk commented Sep 10, 2022

Context

  • Allow testing the settings integration on Yoast SEO free as well, and improve the conditional logic.

Summary

This PR can be summarized in the following changelog entry:

  • None needed.

Relevant technical choices:

  • Instead of having a conditional with conditionals within it, just pass an array of conditionals.\
  • Allow testing on Yoast SEO free too.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Enable the new settings UI with Yoast Test Helper on a site with only Yoast SEO, not running Premium.

Relevant test scenarios

  • Changes should be tested on multisite

Not sure whether multisite is affected, but we should test.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Quality assurance

  • I have tested this code to the best of my abilities

@jdevalk jdevalk added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant