Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure we have a URL when the canonical is empty #18604

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Make sure we have a URL when the canonical is empty #18604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Make sure we have a URL when the canonical is empty
  • Loading branch information
@jdevalk
jdevalk committed Jun 22, 2022
commit ea4211bfd29134481ab4de0a7bca4409378f2b84
6 changes: 5 additions & 1 deletion src/context/meta-tags-context.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,11 @@ public function generate_description() {
* @return string the canonical
*/
public function generate_canonical() {
return $this->presentation->canonical;
if ( ! empty( $this->presentation->canonical ) ) {
return $this->presentation->canonical;
}

return $this->url->recreate_current_url();
}

/**
Expand Down