Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Options_Conditional and use it for enable_headless_rest_endpoints. #18347

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

herregroen
Copy link
Contributor

Context

  • Introduces new conditionals with dynamic arguments and adds the first, the Options_Conditional. Implementing it for the headless REST API feature toggle.

Summary

This PR can be summarized in the following changelog entry:

  • Deprecates the Headless_Rest_Endpoints_Enabled_Conditional.

Relevant technical choices:

  • The Headless_Rest_Endpoints_Enabled_Conditional is replaced by the dynamic Options_Conditional.
  • The Options_Conditional does not implement an interface as PHP interfaces are not expressive enough to allow for a dynamic number of arguments without forcing splat arguments on every implementation.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • The headless REST endpoint output, see the original two PRs for more details.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.

@herregroen herregroen added the changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog label Apr 20, 2022
@enricobattocchi enricobattocchi self-assigned this Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: non-user-facing Needs to be included in the 'Non-userfacing' category in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants