Bypass post meta, first pass #16628
Bypass post meta, first pass #16628
Conversation
jdevalk
added
the
changelog: enhancement
| return $check; | ||
| } | ||
| $field = $this->map_meta_indexable[ $key ]; | ||
| $indexable = $this->indexable_repository->find_by_id_and_type( $object_id, $meta_type, false ); |
There was a problem hiding this comment.
Passing false to the auto-create here means this can potentially return false instead of an indexable.
Given we want to be sure to store the data I'd recommend not passing the third argument so the indexable is auto-created.
Do note that even in that case it's still possible for false ( for indexables that should not be indexed ) or an indexable with the post_status unindexed to be created ( for indexables of objects that do not exist ).
if ( $indexable === false || $indexable->post_status === 'unindexed' ) {
return false;
}
| return $value; | ||
| } | ||
| $field = $this->map_meta_indexable[ $key ]; | ||
| $indexable = $this->indexable_repository->find_by_id_and_type( $object_id, $meta_type, false ); |
There was a problem hiding this comment.
This could also return false if the indexable hasn't been created yet ( not creating it is fine as we there'd be no data to read.
If the $indexable is false we should likely return false here as well.
There was a problem hiding this comment.
we should return the $check value, but yeah agreed. fixing.
|
@jdevalk Is this still relevant or can it be closed? |
|
Let’s close
…On Fri, 23 Sep 2022 at 10:23, Irene ***@***.***> wrote:
@jdevalk <https://github.com/jdevalk> Is this still relevant or can it be
closed?
—
Reply to this email directly, view it on GitHub
<#16628 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADXBTKVDR4UACSIQ7B22Y3V7VSHBANCNFSM4XDBPMBQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Documentation
Quality assurance
Fixes #