Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed sorting of taxonomies in breadcrumbs to go for term_order instead of name #158

Merged
merged 3 commits into from
Aug 8, 2013

Conversation

Gaya
Copy link
Contributor

@Gaya Gaya commented Aug 7, 2013

It will order by oldest ancestor instead of its own name.

@jdevalk
Copy link
Contributor

jdevalk commented Aug 7, 2013

term_order isn't always set, which makes this code throw notices on both line 120 and 126, can you fix those?

@Gaya
Copy link
Contributor Author

Gaya commented Aug 7, 2013

Sure! Didn't cross my mind ;)

On 7 Aug 2013, at 21:02, Joost de Valk [email protected] wrote:

term_order isn't always set, which makes this code throw notices on both line 120 and 126, can you fix those?


Reply to this email directly or view it on GitHub.

jdevalk pushed a commit that referenced this pull request Aug 8, 2013
Fixed sorting of taxonomies in breadcrumbs to go for term_order instead of name
@jdevalk jdevalk merged commit d992d8a into Yoast:master Aug 8, 2013
seripap pushed a commit to seripap/wordpress-seo that referenced this pull request Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants