-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduces a wrapper method for easily disabling the oAuth way. #12399
Merged
igorschoester
merged 6 commits into
trunk
from
temporary-disable-oauth-connection-with-my-yoast
Mar 11, 2019
Merged
Introduces a wrapper method for easily disabling the oAuth way. #12399
igorschoester
merged 6 commits into
trunk
from
temporary-disable-oauth-connection-with-my-yoast
Mar 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yoast * trunk: Fix Travis build (#12403) Use the correct profileUrls field for Wikipedia
CR 🚧 Locally, I get this with PHPUnit 6.5.8:
|
I've marked |
CR 2 👍 |
Acceptance ✅ |
igorschoester
deleted the
temporary-disable-oauth-connection-with-my-yoast
branch
March 11, 2019 14:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Previously the add-ons update process would go through the license manager. This got rewritten with the MyYoast connection flow. Unfortunately, this is more complicated and should get reverted a bit for now.
Therefore, we should test if the detecting and actual updating of the add-ons functions as before.
Check Again
button in theDashboard - Updates
page).UI changes
Quality assurance
Fixes #