Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces a wrapper method for easily disabling the oAuth way. #12399

Merged
merged 6 commits into from
Mar 11, 2019

Conversation

andizer
Copy link
Contributor

@andizer andizer commented Mar 8, 2019

Summary

This PR can be summarized in the following changelog entry:

  • N/A -

Relevant technical choices:

  • Made a wrapper for easily disabling the oauth feature. This returns false at the moment. Should be returning the commented value when oAuth is implemented.
  • Also commented out the oAuth loader, to make sure the oAuth feature isn't loaded.

Test instructions

This PR can be tested by following these steps:

Previously the add-ons update process would go through the license manager. This got rewritten with the MyYoast connection flow. Unfortunately, this is more complicated and should get reverted a bit for now.

Therefore, we should test if the detecting and actual updating of the add-ons functions as before.

  • Install an older version of an add-on (see releases tab on GitHub).
  • Ensure that it still detects that there is a newer version available (it should see this on the plugins page, but there is also a Check Again button in the Dashboard - Updates page).
  • Ensure that updating the add-on works.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #

…yoast

* trunk:
  Fix Travis build (#12403)
  Use the correct profileUrls field for Wikipedia
@afercia afercia self-assigned this Mar 11, 2019
@afercia
Copy link
Contributor

afercia commented Mar 11, 2019

CR 🚧 Locally, I get this with PHPUnit 6.5.8:

There was 1 error:

1) Yoast\Tests\UnitTests\Oauth\Oauth_Client_Test::test_get_provider
Error: Call to undefined function YoastSEO_Vendor\GuzzleHttp\choose_handler()

@IreneStr IreneStr added this to the 10.1 milestone Mar 11, 2019
@afercia
Copy link
Contributor

afercia commented Mar 11, 2019

I've marked Yoast\Tests\UnitTests\Oauth\Oauth_Client_Test::test_get_provider as test to skip for now. The test failed because require_once WPSEO_PATH . 'src/loaders/oauth.php'; is now commented thus test_get_provider is undefined.

@afercia
Copy link
Contributor

afercia commented Mar 11, 2019

CR 2 👍

@igorschoester
Copy link
Member

Acceptance ✅

@igorschoester igorschoester merged commit fa06e4b into trunk Mar 11, 2019
@igorschoester igorschoester deleted the temporary-disable-oauth-connection-with-my-yoast branch March 11, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants