-
Notifications
You must be signed in to change notification settings - Fork 894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
%%sep%% variable doesn't resolve in the Snippet Preview #1260
Comments
The replacement variables are supposed to be used for the title/description templates. Not for the actual setting of a title in the SEO Metabox of a post/page. (am I right @jdevalk ?) This behaviour has not changed with the refactor. |
Oh, okay - because the variable does actually work when I use it there! (I mean it works for the actual title itself). It's just the Snippet Preview that it doesn't work for. :) And actually I assumed that this had always worked - I wasn't assuming it was related to the refactor thingy. :) |
@jrfnl You're right that that's by design, but I've often pondered if that's smart. You see, actually being able to use %%sitename%% in a post's title might make sense, as that would make changing the site name a whole lot easier... |
Ah, LOL. Well let's keep it working and I'll do some work to make the snippet preview work better. We should round trip that with AJAX anyway as it's currently entirely unreliable... Would that work after the refactor @jrfnl ? |
@jdevalk Exactly what I was thinking and yes, that should definitely work well after the refactor. Just make sure to set the |
Thanks, both of you! 👍 |
This was fixed by 948233f (but I just realized I could make this shitloads faster so I will in another commit) |
Hi @jdevalk - I've just updated to v1.5.4 and unfortunately this issue is not fixed. When I enter %%sep%% into the "SEO Title" field of the WPSEO meta box when editing a Page, the Snippet Preview (directly above) still shows %%sep%% rather than the actual separator character. FWIW, I'm defining my separator character via a function using the new "wpseo_replacements_filter_sep" filter. |
1.5.4? Or 1.5.4.1? On Tuesday, July 15, 2014, Jeremy [email protected] wrote:
|
It was 1.5.4. I've just now upgraded to 1.5.4.1, which has just come through to my WordPress, and now the issue seems to be fixed - the Snipped Preview is showing the separator character now and not the %%sep%% variable. Thanks! |
I just added %%sep%% to the SEO Title field on my home page, because I want to use the separator symbol in my title there. So the SEO Title field looks like this:
My Site Name %%sep%% My Tag Line
However, in the Snippet Preview shown above this, in the WPSEO meta box, it doesn't resolve the %%sep%% variable to whatever it should be. It just leaves it as %%sep%%, which obviously makes it difficult to visualise how the title will look on Google.
Any chance that could be rectified? (I imagine this issue may also apply to any other variables which are added to the SEO Title field too).
The text was updated successfully, but these errors were encountered: