Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add support for cornerstone setting #6

Merged
merged 2 commits into from
Apr 27, 2018

Conversation

mficzel
Copy link
Contributor

@mficzel mficzel commented Apr 27, 2018

The cornerstone documents are considered especially important by yoast and some special metrics are applied.

The cornerstone documents are considered especially important by yoast and some special metrics are applied.
</trans-unit>
<trans-unit id="properties.isCornerstone">
<source>is Cornerstone</source>
<target>Fokuswort</target>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the wrong translation ;)

@Sebobo
Copy link
Collaborator

Sebobo commented Apr 27, 2018

Awesome thanks!

Can you add a small explanation to the readme too?

Copy link
Collaborator

@Sebobo Sebobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small issue in the translation. And a note about the cornerstone setting in the readme would be great.

@mficzel mficzel force-pushed the feature/supportCornerstoneDocuments branch from 48f4ab2 to 00b74a5 Compare April 27, 2018 14:15
@mficzel
Copy link
Contributor Author

mficzel commented Apr 27, 2018

@Sebobo both fixed

@Sebobo Sebobo merged commit 3cb9ae4 into Yoast:master Apr 27, 2018
@Sebobo
Copy link
Collaborator

Sebobo commented Apr 27, 2018

<3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants