Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make default edit preview mode configurable #73

Closed
bwaidelich opened this issue Dec 15, 2021 · 0 comments · Fixed by #74
Closed

Make default edit preview mode configurable #73

bwaidelich opened this issue Dec 15, 2021 · 0 comments · Fixed by #74

Comments

@bwaidelich
Copy link
Contributor

The SnippetPreviewButton in the custom YoastInfoView switches between the "yoastSeoView" and "inPlace" edit preview mode.

The latter is not always desired. And if the inPlace-mode is disabled, the switch leads to a blank page that requires manual interaction with the neos_neos_domain_model_userpreferences database table to recover from.
bwaidelich added a commit to bwaidelich/Yoast-SEO-for-Neos that referenced this issue Dec 15, 2021
@bwaidelich
FEATURE: Configurable default edit preview mode
d4692c8 
Extends the custom `YoastInfoView` by an option to override the
default edit preview mode (default: "inPlace")

Resolves: Yoast#73
@bwaidelich bwaidelich mentioned this issue Dec 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FEATURE: Configurable default edit preview mode bwaidelich/Yoast-SEO-for-Neos
1 participant
@bwaidelich