Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript error in Yoast Seo View #42

Closed
davidspiola opened this issue Jun 3, 2019 · 7 comments · Fixed by #43
Closed

Javascript error in Yoast Seo View #42

davidspiola opened this issue Jun 3, 2019 · 7 comments · Fixed by #43
Labels
bug

Comments

@davidspiola
Copy link

I do get an js error if I open the "Yoast Seo View" Preview mode with Neos 4.3 and UI 3.4

TypeError: c is null
<anonym> http:https://127.0.0.1:8081/_Resources/Static/Packages/Shel.Neos.YoastSeo/Assets/app.js:17
<anonym> http:https://127.0.0.1:8081/_Resources/Static/Packages/Shel.Neos.YoastSeo/Assets/app.js:17
e http:https://127.0.0.1:8081/_Resources/Static/Packages/Shel.Neos.YoastSeo/Assets/app.js:1
<anonym> http:https://127.0.0.1:8081/_Resources/Static/Packages/Shel.Neos.YoastSeo/Assets/app.js:17
e http:https://127.0.0.1:8081/_Resources/Static/Packages/Shel.Neos.YoastSeo/Assets/app.js:1
<anonym> http:https://127.0.0.1:8081/_Resources/Static/Packages/Shel.Neos.YoastSeo/Assets/app.js:1
<anonym> http:https://127.0.0.1:8081/_Resources/Static/Packages/Shel.Neos.YoastSeo/Assets/app.js:1
@Sebobo
Copy link
Collaborator

Sebobo commented Jun 3, 2019

Sadly cannot reproduce on my machine with 4.3 and UI 3.4.

Which browser are you using with which version and which version of Yoast itself?

@davidspiola
Copy link
Author

First, I tested with latest Firefox and now with Chrome and got a more specific error message.

Uncaught TypeError: Cannot read property 'querySelector' of null

yoast 0.2.2
ui 3.5.0 - sorry
neos 4.3.0

@Sebobo
Copy link
Collaborator

Sebobo commented Jun 3, 2019

Hm, can you try the 1.0.0-beta?

@Sebobo
Copy link
Collaborator

Sebobo commented Jun 3, 2019

Oh and which Neos.Seo version do you use?

@Sebobo Sebobo added the bug label Jun 4, 2019
@davidspiola
Copy link
Author

davidspiola commented Jun 5, 2019 •
edited

With the beta the backend does not work at all => white screen

Host.js?b2187590:553 TypeError: Cannot read property 'backgroundColor' of undefined
    at ContentCanvas.render (Host.js?b2187590:817)
    at ig (Host.js?b2187590:553)
    at hg (Host.js?b2187590:553)
    at pg (Host.js?b2187590:553)
    at Rg (Host.js?b2187590:553)
    at Sg (Host.js?b2187590:553)
    at Xg (Host.js?b2187590:553)
    at Yg (Host.js?b2187590:553)
    at If (Host.js?b2187590:553)
    at wh (Host.js?b2187590:553)

Host.js?b2187590:553 TypeError: Cannot read property 'isEditingMode' of undefined
    at EditModePanel.render (Host.js?b2187590:817)
    at ig (Host.js?b2187590:553)
    at hg (Host.js?b2187590:553)
    at pg (Host.js?b2187590:553)
    at Rg (Host.js?b2187590:553)
    at Sg (Host.js?b2187590:553)
    at Xg (Host.js?b2187590:553)
    at Yg (Host.js?b2187590:553)
    at If (Host.js?b2187590:553)
    at wh (Host.js?b2187590:553)

@davidspiola
Copy link
Author

Oh and which Neos.Seo version do you use?

"neos/seo": "~2.0"

Sebobo added a commit that referenced this issue Jun 5, 2019
@Sebobo
TASK: Refactor app rendering to increase resilience
8b9fd53 
Some projects override the body part of Neos.Neos:Page
and change the rendering. This would lead to
several errors in the yoast app.

Resolves: #42
@Sebobo Sebobo mentioned this issue Jun 5, 2019
Merged
@Sebobo
Copy link
Collaborator

Sebobo commented Jun 5, 2019

The error TypeError: Cannot read property 'backgroundColor' of undefined can be resolved by changing the preview mode before upgrading to 1.x or by removing the stored preview mode in the user preferences via the database. I added that information to the readme FAQ.

The other error is caused by a change to the body part in the Neos.Neos:Page in the specific project which should be resolved by #43

@Sebobo Sebobo closed this as completed in #43 Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TASK: Refactor app rendering to increase resilience Yoast/Yoast-SEO-for-Neos
2 participants
@Sebobo @davidspiola