Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetching the translations every time the analyzer runs can be a bit slow #13

Closed
Sebobo opened this issue May 1, 2018 · 0 comments
Closed

Fetching the translations every time the analyzer runs can be a bit slow #13

Sebobo opened this issue May 1, 2018 · 0 comments
Labels
enhancement good first issue
Milestone
1.0.0

Comments

@Sebobo
Copy link
Collaborator

Sebobo commented May 1, 2018

In dev context it's about 200-400ms for me.
And usually most of the time the exact same file is fetched for every editor.

This should either be cached or simplified in a different way.
@Sebobo Sebobo added this to the 1.0.0 milestone May 1, 2018
Sebobo added a commit that referenced this issue Oct 22, 2018
@Sebobo
FEATURE: Cache inspector translations in store
e916df8 
This keeps the ui from reloading the translations every time
the yoast inspector module is opened.
But the translations will currently still be reloaded when the
backend is reloaded.

Resolves: #13
This was referenced Oct 22, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@Sebobo