Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #25

Merged
merged 8 commits into from
Sep 11, 2018
Merged

Update dependencies #25

merged 8 commits into from
Sep 11, 2018

Conversation

jdumas
Copy link
Contributor

@jdumas jdumas commented Sep 6, 2018

More refactoring under way.

  • Updating CGAL dependency to 4.12 (now pointing to my branch until it gets merged into master).
  • Update Geogram to 1.6.6 and change build type to static on Windows. Removed the patch and updated the README accordingly.
  • Removed submodule in favor of CMake external projects for libigl + geogram, as it's easier to deal with.
  • Also use an external project for CLI11 (I had trouble setting it up on my Windows idk why).
  • Added some CMake shenanigan so that Boost can installed via Hunter. This mean that on Windows if you enable this CMake option there should be nothing else to install (not even CGAL).
  • Also set folders for CMake targets so that it looks nice under Visual Studio/XCode and similar IDEs.

@Yixin-Hu Yixin-Hu merged commit fede85f into Yixin-Hu:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdumas @Yixin-Hu