Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS S3: Add support for assume role duration seconds #466

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

rahull-p
Copy link
Contributor

@rahull-p rahull-p commented Aug 9, 2024

Changes Done

Adds support for configuring session duration while assume role. Defaults to 3600 seconds

Fixes #465

Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others look good to me

src/aws/config.rs Outdated Show resolved Hide resolved
src/aws/config.rs Outdated Show resolved Hide resolved
Copy link
Owner

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit a71e90e into Xuanwo:main Aug 9, 2024
19 checks passed
@rahull-p rahull-p deleted the support-duration-seconds branch August 10, 2024 05:34
TennyZhuang pushed a commit to TennyZhuang/reqsign that referenced this pull request Nov 4, 2024
Changes Done

Adds support for configuring session duration while assume role.
Defaults to 3600 seconds

Fixes Xuanwo#465

---------

Co-authored-by: Rahul <[email protected]>
Xuanwo pushed a commit that referenced this pull request Nov 4, 2024
Changes Done

Adds support for configuring session duration while assume role.
Defaults to 3600 seconds

Fixes #465

---------

Co-authored-by: Rahul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3: Add support for assume role session duration
2 participants