Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels, automatic climbable platform #11

Merged
merged 4 commits into from
Oct 28, 2018
Merged

Conversation

kmck
Copy link
Contributor

@kmck kmck commented Oct 28, 2018

  • Added some labels, including a few that provide some useful hooks for modifying addresses in external tools
  • Added an optional subroutine that automatically create the standable tile for whatever vine/ladder/chain the object is placed on
  • Made some labels and comments a little more accurate
  • Commented the level header macro in all the level data

Copy link
Owner

@Xkeeper0 Xkeeper0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; the level header comments help make it much more readable.

World5TallObjectBottomTiles:
.db BackgroundTile_PalmTreeTrunk
.db BackgroundTile_PalmTreeTrunk


;
; POI: The only practical difference with this subroutine (other than the fact
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I was hoping to see w/r/t the POI comments 👍

@Xkeeper0 Xkeeper0 merged commit 9fc44a7 into Xkeeper0:master Oct 28, 2018
pepperpow pushed a commit to pepperpow/smb2 that referenced this pull request Aug 17, 2021
Labels, automatic climbable platform, level header contents
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants