Corrected the logic in the npu preempt data function #8296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signe-off-by: Durga Prasad <[email protected]>
dkotipal-xilinx
requested review from
maxzhen,
mamin506 and
stsoe
as code owners
dezhiAmd
reviewed
Jul 18, 2024
| @@ -1087,7 +1087,7 @@ get_ert_npu_data(struct ert_start_kernel_cmd* pkt) | |||
| static inline struct ert_npu_preempt_data* | |||
| get_ert_npu_preempt_data(struct ert_start_kernel_cmd* pkt) | |||
| { | |||
| if (pkt->opcode != ERT_START_NPU) | |||
| if (pkt->opcode != ERT_START_NPU_PREEMPT) | |||
There was a problem hiding this comment.
In my humble opinion, this check is not needed at all since this function is an internal function.
In another word, the person who call "get_ert_npu_preempt_data" should ensure that
pkt->opcode == ERT_START_NPU_PREEMPT
is true.
With that being said, we should add
assert(pkt->opcode == ERT_START_NPU_PREEMPT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signe-off-by: Durga Prasad [email protected]
Problem solved by the commit
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)