Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a macOS theme of tkintertools #4

Closed
wants to merge 1 commit into from

Conversation

CodeCrafter-TL
Copy link

No description provided.

@Xiaokang2022 Xiaokang2022 added the ⚠️ Invalid This doesn't seem right label May 20, 2024
@Xiaokang2022
Copy link
Owner

There is some reference, but PRs for themes are not accepted right now.

Copy link
Owner

@Xiaokang2022 Xiaokang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be referred to, but the current theme file is not actually added directly in this way, and it needs to be modified with some modifications in the code.

},
"active": {
"fill": "#ffffff"
}
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you should consider using uppercase color strings? I think it's eye-catching and pretty.

},
"active": {
"fill": "#ffffff"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe you could consider adding a color for the disabled state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ Invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants