Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat(update_replication_factor#5): support to set the replication factor for app-level metadata of each table #1107

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat(update_replication_factor#5): support to set the replication fac…
…tor for app-level metadata of each table
  • Loading branch information
empiredan committed May 18, 2022
commit 9ab1a388713540920e85f1ef406e926956e50cfe
6 changes: 3 additions & 3 deletions src/meta/test/meta_app_operation_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -240,14 +240,13 @@ class meta_app_operation_test : public meta_test_base
// verify local max_replica_count of the app
ASSERT_EQ(app->max_replica_count, expected_max_replica_count);

// verify remote max_replica_count of the app
// verify remote max_replica_count of the app
auto app_path = _ss->get_app_path(*app);
dsn::task_tracker tracker;
_ms->get_remote_storage()->get_data(
app_path,
LPC_META_CALLBACK,
[ this, app, expected_max_replica_count ](
error_code ec, const blob &value) {
[this, app, expected_max_replica_count](error_code ec, const blob &value) {
ASSERT_EQ(ec, ERR_OK);

app_info ainfo;
Expand Down Expand Up @@ -749,6 +748,7 @@ TEST_F(meta_app_operation_test, set_max_replica_count)
ASSERT_EQ(set_resp.old_max_replica_count, test.expected_old_max_replica_count);
if (test.expected_err == ERR_OK) {
verify_all_partitions_max_replica_count(test.app_name, test.new_max_replica_count);
verify_app_max_replica_count(test.app_name, test.new_max_replica_count);
}

const auto get_resp = get_max_replica_count(test.app_name);
Expand Down