Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for VisionOS download #300

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Conversation

MattKiazyk
Copy link
Contributor

@MattKiazyk MattKiazyk commented Jun 22, 2023

Closes #299

Adds support for proper parsing of com.apple.platform.xros - ie: VisionOS. 馃ソ

With this change you can usexcodes runtimes install "visionOS 1.0-beta1"

Copy link

@rszczepanski rszczepanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side and I also quickly compiled and verified the new binary In the field on our CI systems.

Thank you @MattKiazyk for your work. 馃憤

@beechtom
Copy link

@MattKiazyk Does InstalledRuntime.Platform also need to be updated to handle visionOS?

@MattKiazyk MattKiazyk merged commit fe98e73 into main Jun 23, 2023
2 checks passed
@MattKiazyk MattKiazyk deleted the matt/xrOSRuntimeSupport branch June 23, 2023 14:05
@MattKiazyk MattKiazyk added the enhancement New feature or request label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime downloads are broken
4 participants