Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mocks when writing the cache file in unit tests #227

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Use mocks when writing the cache file in unit tests #227

merged 1 commit into from
Oct 14, 2022

Conversation

rpendleton
Copy link
Contributor

After running the unit tests while working on #226, I noticed xcodes list was returning fake versions of Xcode. It looks like this is actually a pre-existing issue with the unit tests, so I figured I'd open a separate PR to fix it.

@rpendleton rpendleton requested a review from a team as a code owner October 3, 2022 09:10
Copy link
Contributor

@MattKiazyk MattKiazyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

@MattKiazyk MattKiazyk merged commit 914a1b1 into XcodesOrg:main Oct 14, 2022
@MattKiazyk MattKiazyk added the chore Repo upkeep label Oct 14, 2022
@rpendleton rpendleton deleted the mock-file-writes-in-unit-tests branch October 14, 2022 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants