Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with downloading Release Candidate builds #168

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

fishcharlie
Copy link
Contributor

Closes #167

@fishcharlie fishcharlie requested a review from a team as a code owner December 8, 2021 17:10
@fishcharlie
Copy link
Contributor Author

@MattKiazyk Any chance I could get a review on this PR and if approved & merged a new release?

Normally I would just point my local environment to this branch so that I'm not having to wait for a new release, but I'm not sure how to do that since I installed through Homebrew. 😢. So that increases the priority and urgency for me to get this merged in with a new release.

@atlas-foreflight
Copy link

Just chiming in a word of support for this PR! Thanks @fishcharlie 👍

@MattKiazyk
Copy link
Contributor

Thanks @fishcharlie - while I prefer to have this matching to what XcodeApp does - https://github.com/RobotsAndPencils/XcodesApp/blob/main/Xcodes/Backend/Version%2BXcode.swift#L17 there's still some changes around duplicate builds that still needs to be pulled in xcodes.

This works good. Only thing I'd like to see is to get the tests passing. You can run tests locally by running swift test

The failing tests are:

/Users/runner/work/xcodes/xcodes/Tests/XcodesKitTests/Version+XcodeTests.swift:16: error: -[XcodesKitTests.VersionXcodeTests test_InitXcodeVersion] : XCTAssertEqual failed: ("Optional(10.2.0-gm.seed)") is not equal to ("Optional(10.2.0-gm-seed)")
/Users/runner/work/xcodes/xcodes/Tests/XcodesKitTests/Version+XcodeTests.swift:17: error: -[XcodesKitTests.VersionXcodeTests test_InitXcodeVersion] : XCTAssertEqual failed: ("Optional(10.2.0-gm.seed.1)") is not equal to ("Optional(10.2.0-gm-seed.1)")
/Users/runner/work/xcodes/xcodes/Tests/XcodesKitTests/Version+XcodeTests.swift:18: error: -[XcodesKitTests.VersionXcodeTests test_InitXcodeVersion] : XCTAssertEqual failed: ("Optional(10.2.0-gm.seed.2)") is not equal to ("Optional(10.2.0-gm-seed.2)")

I'd also like to see another test added for the "release candidate" option.

@fishcharlie
Copy link
Contributor Author

@MattKiazyk That should be fixed. Let me know if there is anything else!!

@MattKiazyk MattKiazyk merged commit 4cc0d59 into XcodesOrg:main Dec 14, 2021
@MattKiazyk
Copy link
Contributor

Thanks @fishcharlie

@fishcharlie fishcharlie deleted the issue167 branch December 16, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Could not find version 13.2 Release Candidate.
3 participants