Don't output download progress when in a non-interactive terminal #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interstateone
force-pushed
the
remove-non-interactive-progress
branch
from
4b3dd6f
to
1487d86
Compare
MattKiazyk
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change disables download progress output if
xcodesisn't running in an interactive terminal. In an interactive terminalxcodeswill update the same line with progress from 0-100%. In a non-interactive terminalxcodesused to write 100 separate lines with the ANSI escape codes, and now it'll only print(1/6) Downloading Xcode X.Y.Zonce.This is not the only change that should be made for better support of non-interactive terminals (for example #128, or any other use of readline), but it's a start.