This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Dynamic Mask: Implement sRGB and HDR support, and fix #819 #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaymar
force-pushed
the
bug/819-dynamic-mask-causes-double-free-crash
branch
6 times, most recently
from
4b791cc
to
2447c13
Compare
|
This PR marks Dynamic Mask as the first SDR and HDR compatible filter in StreamFX. It was a challenge to get this to work, but here we are! |
The rendering code here was one of the older code bases, which was riddled with bugs and leaks. The new code doesn't look pretty, but it works for the time being until a better solution is found or made. It should be able to handle HDR inputs now, but it may not be completely correct yet. This also fixes the double-free bug. As an additional improvement, I've moved the allocation of the effect to a shared class which should reduce the memory usage slightly when multiple effects are in play. And now selecting nothing selects the filter target itself without infinitely adding references to the filter. Good enough in my eyes. Fixes #819
Xaymar
force-pushed
the
bug/819-dynamic-mask-causes-double-free-crash
branch
from
2447c13
to
48f57a3
Compare
Xaymar
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
Fixes #819 (see commits).
Completion Checklist
CODEOWNERS.