Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

cmake: Fix bad version strings #887

Merged
merged 1 commit into from
Aug 22, 2022
Merged

cmake: Fix bad version strings #887

merged 1 commit into from
Aug 22, 2022

Conversation

Xaymar
Copy link
Owner

@Xaymar Xaymar commented Aug 21, 2022

Explain the Pull Request

PROJECT_VERSION is defined by CMake, and can't be relied on.

Completion Checklist

  • I have added myself to the Copyright and License headers and files.
  • I will maintain this code in the future and have added myself to CODEOWNERS.
  • I have tested this change on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11

@Xaymar Xaymar marked this pull request as draft August 21, 2022 05:32
@Xaymar Xaymar force-pushed the patch/version branch 2 times, most recently from 02a2a1f to d868740 Compare August 22, 2022 10:34
PROJECT_VERSION is defined by CMake, and can't be relied on.
@Xaymar Xaymar marked this pull request as ready for review August 22, 2022 11:57
@Xaymar Xaymar merged commit c45222b into master Aug 22, 2022
@Xaymar Xaymar deleted the patch/version branch August 22, 2022 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant