Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Deprecate AMD AMF encoders #885

Merged
merged 1 commit into from
Aug 21, 2022
Merged

Deprecate AMD AMF encoders #885

merged 1 commit into from
Aug 21, 2022

Conversation

Xaymar
Copy link
Owner

@Xaymar Xaymar commented Aug 20, 2022

Explain the Pull Request

As the FFmpeg implementation of AMD AMF is in an even worse state than obs-amd-encoder, these encoders should not be used at all by any sane person. Therefore they are deprecated as of v0.12, with a warning that they'll be removed eventually.

Completion Checklist

  • I have added myself to the Copyright and License headers and files.
  • I will maintain this code in the future and have added myself to CODEOWNERS.
  • I have tested this change on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11

@Xaymar Xaymar force-pushed the patch/deprecate-ffmpeg-amdamf branch from 33350d0 to 1d97cff Compare August 20, 2022 21:38
@Xaymar Xaymar marked this pull request as ready for review August 20, 2022 21:40
@Xaymar Xaymar force-pushed the patch/deprecate-ffmpeg-amdamf branch from 1d97cff to 06766d7 Compare August 20, 2022 21:43
@GloriousEggroll
Copy link

GloriousEggroll commented Aug 21, 2022

just wanted to note that these encoders work well on linux using the proprietary AMF drivers, and perform much better than the FFMPEG VAAPI encoders built into OBS. I would recommend leaving them for linux usage. It even works if I roll back to older drivers on older cards like R9 390x. There is a new gstreamer VAAPI encoder plugin that works extremely well (in fact its the only one that can record 4k60 given a powerful enough card -- tested on 6900 XT). I am trying to push for that encoder to replace the current FFMPEG VAAPI open source encoder, but for the proprietary AMF drivers streamfx is literally our only option on linux, especially considering OBS upstream's AMF encoder is windows-only.

@Xaymar
Copy link
Owner Author

Xaymar commented Aug 21, 2022

especially considering OBS upstream's AMF encoder is windows-only.

You should probably ask upstream to support Linux then. The FFmpeg integration of AMD AMF is horribly outdated and does not support any of the metadata required to make OBS Studio 28.0 work.

@Xaymar Xaymar merged commit d3e99fb into master Aug 21, 2022
@Xaymar Xaymar deleted the patch/deprecate-ffmpeg-amdamf branch August 21, 2022 04:33
@Xaymar Xaymar added this to the FFmpeg Encoders (Component) milestone Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants