This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
project: Code cleanup and reapply formatting #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba12fd5
to
4c71fcf
Compare
Changes applied: * Moved utility files to /util/. * Removed unused #includes. * Removed unused ::ffmpeg::tools function. * Removed unused variables. * Fixed missing parentheses in the version macro. * Fixed missing override on virtual function overrides and removed unnecessary virtual keyword from them. * Disabled additional warning for ATL headers on MSVC only. * Replaced direct printf parameters with their macro equivalent. * Replaced C-style casts with C++-style casts. * Applied clang-format again after an earlier change to the CMake file broke the integration for it.
Using '-Wpedantic' on any GCC warnings enables a lot of annoying warnings that don't actually warn about anything. Some of the warnings seem to exist purely for maintaining a certain code style, and have no actual effect on the program itself. Since there is no way to selectively disable warnings like on MSVC, removing it is the easiest choice.
Fixes several warnings and potential memory corruptions that could happen. Also makes the entire thing easier to read.
Xaymar
added a commit
that referenced
this pull request
Jul 29, 2020
* #270 Add additional shadertoy effects (by Oncorporation/Surn). * #275 Improve installer user experience. * #277 Add CI caching to improve build speeds. * #286 Rename LOG_ to DLOG_ to avoid macro confusion. * #287 Add new 'Thank You' entries. * #288 Fix memory leaks caused by obs::source_tracker. * #289 Fix memory leaks caused by configuration and UI. * #290 Don't use namespaces that don't exist. * #292 Fix/Work around a memory leak in gs::vertex_buffer. * #293 Fix missing include in plugin.hpp. * #294 Fix Clang toolset integration. * #296 Fix FFmpeg encoder fallback support. * #298 Fix NVENC logging incorrect values. * #300 Remove level 5.2 from NVENC H.264. * #301 Show warnings for exceptions thrown from tasks in a threadpool. * #302 Clean up code to fix all warnings and reapply formatting.
Merged
Xaymar
added a commit
that referenced
this pull request
Jul 29, 2020
* #270 Add additional shadertoy effects (by Oncorporation/Surn). * #275 Improve installer user experience. * #277 Add CI caching to improve build speeds. * #286 Rename LOG_ to DLOG_ to avoid macro confusion. * #287 Add new 'Thank You' entries. * #288 Fix memory leaks caused by obs::source_tracker. * #289 Fix memory leaks caused by configuration and UI. * #290 Don't use namespaces that don't exist. * #292 Fix/Work around a memory leak in gs::vertex_buffer. * #293 Fix missing include in plugin.hpp. * #294 Fix Clang toolset integration. * #296 Fix FFmpeg encoder fallback support. * #298 Fix NVENC logging incorrect values. * #300 Remove level 5.2 from NVENC H.264. * #301 Show warnings for exceptions thrown from tasks in a threadpool. * #302 Clean up code to fix all warnings and reapply formatting. * #304 Update Ubuntu 19.10 to 20.04 and revert to system-installed clang.
Xaymar
added a commit
that referenced
this pull request
Jul 29, 2020
* #270 Add additional shadertoy effects (by Oncorporation/Surn). * #275 Improve installer user experience. * #277 Add CI caching to improve build speeds. * #286 Rename LOG_ to DLOG_ to avoid macro confusion. * #287 Add new 'Thank You' entries. * #288 Fix memory leaks caused by obs::source_tracker. * #289 Fix memory leaks caused by configuration and UI. * #290 Don't use namespaces that don't exist. * #292 Fix/Work around a memory leak in gs::vertex_buffer. * #293 Fix missing include in plugin.hpp. * #294 Fix Clang toolset integration. * #296 Fix FFmpeg encoder fallback support. * #298 Fix NVENC logging incorrect values. * #300 Remove level 5.2 from NVENC H.264. * #301 Show warnings for exceptions thrown from tasks in a threadpool. * #302 Clean up code to fix all warnings and reapply formatting. * #304 Update Ubuntu 19.10 to 20.04 and revert to system-installed clang.
Xaymar
added a commit
that referenced
this pull request
Jul 29, 2020
* #270 Add additional shadertoy effects (by Oncorporation/Surn). * #275 Improve installer user experience. * #277 Add CI caching to improve build speeds. * #286 Rename LOG_ to DLOG_ to avoid macro confusion. * #287 Add new 'Thank You' entries. * #288 Fix memory leaks caused by obs::source_tracker. * #289 Fix memory leaks caused by configuration and UI. * #290 Don't use namespaces that don't exist. * #292 Fix/Work around a memory leak in gs::vertex_buffer. * #293 Fix missing include in plugin.hpp. * #294 Fix Clang toolset integration. * #296 Fix FFmpeg encoder fallback support. * #298 Fix NVENC logging incorrect values. * #300 Remove level 5.2 from NVENC H.264. * #301 Show warnings for exceptions thrown from tasks in a threadpool. * #302 Clean up code to fix all warnings and reapply formatting. * #304 Update Ubuntu 19.10 to 20.04 and revert to system-installed clang.
Xaymar
added a commit
that referenced
this pull request
Mar 27, 2023
* #270 Add additional shadertoy effects (by Oncorporation/Surn). * #275 Improve installer user experience. * #277 Add CI caching to improve build speeds. * #286 Rename LOG_ to DLOG_ to avoid macro confusion. * #287 Add new 'Thank You' entries. * #288 Fix memory leaks caused by obs::source_tracker. * #289 Fix memory leaks caused by configuration and UI. * #290 Don't use namespaces that don't exist. * #292 Fix/Work around a memory leak in gs::vertex_buffer. * #293 Fix missing include in plugin.hpp. * #294 Fix Clang toolset integration. * #296 Fix FFmpeg encoder fallback support. * #298 Fix NVENC logging incorrect values. * #300 Remove level 5.2 from NVENC H.264. * #301 Show warnings for exceptions thrown from tasks in a threadpool. * #302 Clean up code to fix all warnings and reapply formatting. * #304 Update Ubuntu 19.10 to 20.04 and revert to system-installed clang.
Xaymar
added a commit
that referenced
this pull request
Mar 28, 2023
* #270 Add additional shadertoy effects (by Oncorporation/Surn). * #275 Improve installer user experience. * #277 Add CI caching to improve build speeds. * #286 Rename LOG_ to DLOG_ to avoid macro confusion. * #287 Add new 'Thank You' entries. * #288 Fix memory leaks caused by obs::source_tracker. * #289 Fix memory leaks caused by configuration and UI. * #290 Don't use namespaces that don't exist. * #292 Fix/Work around a memory leak in gs::vertex_buffer. * #293 Fix missing include in plugin.hpp. * #294 Fix Clang toolset integration. * #296 Fix FFmpeg encoder fallback support. * #298 Fix NVENC logging incorrect values. * #300 Remove level 5.2 from NVENC H.264. * #301 Show warnings for exceptions thrown from tasks in a threadpool. * #302 Clean up code to fix all warnings and reapply formatting. * #304 Update Ubuntu 19.10 to 20.04 and revert to system-installed clang.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes many of the warnings, modernizes code, and reapplies formatting where possible - which wasn't being applied automatically due to a bug in the CMakeLists file.
Related Issues