Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring unit tests + creating first steps to test retry count. #50

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Refactoring unit tests + creating first steps to test retry count. #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refactoring some unit tests, creating first steps to test retry count… 
…s. Please give feedback on recursive method execution testing.
  • Loading branch information
Damiano Patane committed Oct 28, 2019
commit d6f1880f47b84e2a702e19c1f41d97aa5ef5ef9a
37 changes: 37 additions & 0 deletions tests/Xablu.WebApiClient.Tests/RefitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
using System;
using System.Threading.Tasks;
using Moq;
using Xablu.WebApiClient.Client;
using Xablu.WebApiClient.Enums;
using Xablu.WebApiClient.Services.GraphQL;
using Xunit;

namespace Xablu.WebApiClient.Tests
{
public class RefitTests
{
[Fact]
public void CheckRetryCount()
{
// mock dependencies
var refitService = new Mock<IRefitService<IStarwarsApi>>();
var graphqlService = new Mock<IGraphQLService>();
var mockedAPI = new Mock<IStarwarsApi>();

// setup dependency mocks
refitService.SetupGet(s => s.GetByPriority(Priority.UserInitiated)).Returns(mockedAPI.Object);
mockedAPI.Setup(api => api.Get()).Returns(Task.CompletedTask);

var client = new WebApiClient<IStarwarsApi>(refitService.Object, graphqlService.Object);

// complete call
var call = client.Call(api => api.Get());

// check if call has retried according to count
if (call.Status != TaskStatus.Faulted)
{
// do something next to check retry counts...
}
}
}
}
20 changes: 12 additions & 8 deletions tests/Xablu.WebApiClient.Tests/WebApiClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
using Moq;
using Refit;
using Xablu.WebApiClient.Client;
using Xablu.WebApiClient.Enums;
using Xablu.WebApiClient.Services.GraphQL;
using Xunit;

namespace Xablu.WebApiClient.Tests
Expand All @@ -19,34 +21,36 @@ public class WebApiClientTests
public void EnsureUserInitiatedIsSelectedByDefault()
{
// mock dependencies
var service = new Mock<IRefitService<IStarwarsApi>>();
var refitService = new Mock<IRefitService<IStarwarsApi>>();
var graphqlService = new Mock<IGraphQLService>();
var mockedAPI = new Mock<IStarwarsApi>();

// setup dependency mocks
service.SetupGet(s => s.UserInitiated).Returns(mockedAPI.Object);
refitService.SetupGet(s => s.GetByPriority(Priority.UserInitiated)).Returns(mockedAPI.Object);
mockedAPI.Setup(api => api.Get()).Returns(Task.CompletedTask);

var client = new WebApiClient<IStarwarsApi>(service.Object);
var client = new WebApiClient<IStarwarsApi>(refitService.Object, graphqlService.Object);

// execute sentence to test
client.Call(api => api.Get());

// make sure UserInitiated was called
service.VerifyGet(s => s.UserInitiated);
refitService.VerifyGet(s => s.GetByPriority(Priority.UserInitiated));
}

[Fact]
public void EnsureOperationIsCalledInTheRefitAPI()
{
// mock dependencies
var service = new Mock<IRefitService<IStarwarsApi>>();
var refitService = new Mock<IRefitService<IStarwarsApi>>();
var graphqlService = new Mock<IGraphQLService>();
var mockedAPI = new Mock<IStarwarsApi>();

// setup dependency mocks
service.SetupGet(s => s.UserInitiated).Returns(mockedAPI.Object);
mockedAPI.Setup(api => api.Get()).Returns(Task.CompletedTask).Verifiable();
refitService.SetupGet(s => s.GetByPriority(Priority.UserInitiated)).Returns(mockedAPI.Object);
mockedAPI.Setup(api => api.Get()).Returns(Task.CompletedTask);

var client = new WebApiClient<IStarwarsApi>(service.Object);
var client = new WebApiClient<IStarwarsApi>(refitService.Object, graphqlService.Object);

// execute sentence to test
client.Call(api => api.Get());
Expand Down