add fields for refresh token and expiry timestamps #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebRollen
commented
Oct 27, 2023
Comment on lines
+114
to
+116
| expires_in: Option<usize>, | ||
| refresh_token: Option<String>, | ||
| refresh_token_expires_in: Option<usize>, |
There was a problem hiding this comment.
The size of expires_in and refresh_token_expires_in are currently fixed at 28800 and 15811200, respectively, so we could size down these fields to be Option<u16> and Option<u32>. I just copied the precedent for the Claims struct here
|
Thank you for your PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub now supports expiring access tokens.
For these tokens, GitHub sends additional fields in the OAuth response, namely
expires_in,refresh_tokenandrefresh_token_expires_in. This pull request optionally adds these fields to the OAuth response struct so that they can be used by applications that are using expiring access tokens.