Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Remove Gutenberg plugin activation e2e test #6397

Closed

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Apr 16, 2024

Remove tests/e2e/specs/gutenberg-plugin.test.js from the 6.3 branch.

See #6396:

The purpose of tests/e2e/specs/gutenberg-plugin.test.js is to ensure that running the Gutenberg plugin (stable version) on a WordPress trunk install doesn't produce any fatals.

The test has been around since WP 6.2. It makes sense to have it present on older branches, as the Gutenberg plugin not only supports trunk, but also the current stable version of WordPress (i.e. currently 6.5), and one version below (6.4). However, it is not expected to work on any earlier versions beyond that; in practice, it has produced errors on some of those.
[...]
[#6396] cannot be cherry-picked to 6.3 and prior as the test was refactored (from Puppeteer to Playwright) after 6.3.

There's a Gutenberg counterpart PR (WordPress/gutenberg#60780) to bump the GB plugin's minimum required WP version to 6.4.

Trac ticket: https://core.trac.wordpress.org/ticket/60971


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ockham ockham self-assigned this Apr 16, 2024
@ockham ockham closed this Apr 26, 2024
@ockham ockham deleted the remove/gutenberg-plugin-e2e-test-from-6-3 branch April 26, 2024 10:32
@ockham ockham restored the remove/gutenberg-plugin-e2e-test-from-6-3 branch April 26, 2024 10:32
@ockham ockham reopened this Apr 26, 2024
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props bernhard-reiter.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ockham
Copy link
Contributor Author

ockham commented Apr 26, 2024

Thank you @swissspidy!

Committed to Core's 6.3 branch in https://core.trac.wordpress.org/changeset/58047.

@ockham ockham closed this Apr 26, 2024
@ockham ockham deleted the remove/gutenberg-plugin-e2e-test-from-6-3 branch April 26, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants