Show a warning when a disallowed filetype is dropped on a MediaUpload #9578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Sep 3, 2018
| message: [ | ||
| <strong key="filename">{ mediaFile.name }</strong>, | ||
| ': ', | ||
| __( 'Sorry, this file type is not supported by this block.' ), |
There was a problem hiding this comment.
We're outside of the block's code in this function, it can be used in a block agnostic context. Should remove "block" from the message and the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When trying to upload a disallowed filetype to a file block, or an unsupported filetype to a restricted block (eg, a zip file to an image block), there's no feedback saying why the upload failed.
This PR re-arranges the filetype checking a little, to ensure a message is triggered on the former case, and adds a new message for the latter. It also adds the filename to each warning, so the person uploading the files knows which files caused which warning.
Fixes #9467.
How has this been tested?
foo.exe) to a file block.bar.zip) to an image block.Screenshots
Checklist: