Add has_block function and unit tests for it #9058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
obenland
requested changes
Aug 16, 2018
lib/register.php
Outdated
| } | ||
| } | ||
|
|
||
| if ( ! has_blocks( $post ) ) { |
There was a problem hiding this comment.
This check could probably moved to the top of the function. If there are no blocks, getting the post before hand seems superfluous.
obenland
approved these changes
Aug 16, 2018
|
@mtias Looks like this is too late for 3.6? |
3 tasks
|
Wonderful, thanks @andreilupu! I think we can safely put this into 3.6, it's a useful addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A refresh for #8340
How has this been tested?
Screenshots
Types of changes
Checklist: