Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix canvas jumb when navigation regions #9014

Merged
merged 1 commit into from
Aug 15, 2018
Merged

Fix canvas jumb when navigation regions #9014

merged 1 commit into from
Aug 15, 2018

Conversation

youknowriad
Copy link
Contributor

closes #9006

This PR simplifies the styling of the "Toggle publish panel" aria region to avoid content jumps.

Testing instructions

  • Write a long post (requires scrolling)
  • Navigate regions using Alt + Shift + N
  • The content shouldn't jump/scroll when focusing the "Open publish panel" region.

@youknowriad youknowriad self-assigned this Aug 15, 2018
@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Aug 15, 2018
@youknowriad youknowriad added this to the 3.6 milestone Aug 15, 2018
jasmussen
jasmussen approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, this appears to fix it for me!

@youknowriad youknowriad merged commit 7461f5d into master Aug 15, 2018
@youknowriad youknowriad deleted the fix/canvas-jump branch August 15, 2018 15:36
@afercia
Copy link
Contributor

afercia commented Aug 15, 2018

I'm mobile so can't fully follow but I think this was addressed in #8554 where it was also noted that :focus-within is not supported in IE11 an Edge so it needs to be refactored anyways. /Cc @jasmussen @youknowriad

@jasmussen
Copy link
Contributor

Alright, let's get that in as well, but it needs a rebase.

@afercia afercia mentioned this pull request Aug 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

@afercia afercia Awaiting requested review from afercia

Assignees

@youknowriad youknowriad

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

Regression with region switching and new Publish region
3 participants
@youknowriad @afercia @jasmussen