Refactor template select field to use SelectControl #8987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
reviewed
Aug 15, 2018
| <SelectControl | ||
| label={ __( 'Template:' ) } | ||
| value={ selectedTemplate } | ||
| onChange={ ( value ) => onUpdate( value ) } |
There was a problem hiding this comment.
It could be simplified: onChange={ onUpdate }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #8985 by refactoring the template select field to use
SelectControlinstead of an inline<select>. This applies the appropriate classes and such so the spacing is correct.How has this been tested?
Visually in browser, ran automated tests, Travis passes
Screenshots
Before:
After:
Types of changes
Replaces
<select>with<SelectControl>.My main concern is that previously this select also had an
onBlurhandler, but there isn't anonBluroption on<SelectControl>so I removed it. This might be a huge mistake! In my testing it didn't seem to cause any issues, but it is worth noting.I also removed the use of
withInstanceIdbecause that's natively supported inSelectControl, but again this could be a giant mistake.Checklist: