Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates docs for templateLock's insert option #8843

Merged

Conversation

chrisvanpatten
Copy link
Member

@chrisvanpatten chrisvanpatten commented Aug 10, 2018

Description

templateLock now correctly locks deletion (not sure exactly when this happened, but the logic is correct here) but the docs weren't updated to reflect this change. This fixes that.

How has this been tested?

Tested by reading the docs

Types of changes

Updates documentation

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@chrisvanpatten
Copy link
Member Author

This PR replaces #8201, and I'm flagging @youknowriad for a review because he reviewed that PR 😁

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it was accidentally fixed in #8279 :)

@chrisvanpatten chrisvanpatten merged commit 2d1e3e0 into WordPress:master Aug 10, 2018
@chrisvanpatten chrisvanpatten deleted the fix/templatelock-insert-docs branch August 10, 2018 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants