Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds export getBlockTypes to be used in react native #8457

Merged
merged 1 commit into from
Aug 4, 2018
Merged

Adds export getBlockTypes to be used in react native #8457

merged 1 commit into from
Aug 4, 2018

Conversation

mzorz
Copy link
Contributor

@mzorz mzorz commented Aug 3, 2018

Description

This PR just adds getBlockTypes to the exported functions from ./registration to the React Native side of things. Should not affect Gutenberg (web) at all.

@mzorz mzorz added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Aug 3, 2018
@mzorz mzorz requested review from gziolo and hypest August 3, 2018 17:16
gziolo
gziolo approved these changes Aug 3, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gziolo gziolo merged commit e493909 into master Aug 4, 2018
@gziolo gziolo deleted the rnmobile/export-getblocktypes-2 branch August 4, 2018 10:01
@gziolo gziolo added this to the 3.5 milestone Aug 4, 2018
@mzorz mzorz mentioned this pull request Aug 13, 2018
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@hypest hypest Awaiting requested review from hypest

Assignees
No one assigned
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@mzorz @gziolo