Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link rel and link class to image block inspector (see #7504) #7771

Merged
merged 16 commits into from
Nov 19, 2018
Merged

Add link rel and link class to image block inspector (see #7504) #7771

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
bde8135
Add link classes and rel attribute to image block (see #7504)
Jul 7, 2018
bedb73c
Make labels consistent with classic editor.
Jul 7, 2018
3c6f9da
Fix coding standards error
Jul 7, 2018
dfff33c
Add tests
Jul 7, 2018
c5bfce5
Consolidate check for presence of image link
Jul 8, 2018
41bd3d9
Rebase, incorporate upstream changes
Oct 30, 2018
d538faf
Merge branch 'upstream' into add/image-details
Oct 30, 2018
976f59d
Merge branch 'master' into add/image-details
Nov 6, 2018
05e7ebf
Changes as per review
Nov 9, 2018
3b5dc11
Merge branch 'upstream' into add/image-details
Nov 9, 2018
38f669a
Fix tests
Nov 9, 2018
b4e4409
Merge branch 'upstream' into add/image-details
Nov 10, 2018
df50d10
Merge branch 'upstream' into add/image-details
Nov 13, 2018
48dc15f
Resolve final review comment
Nov 13, 2018
2b44182
Update CONTRIBUTORS.md
Nov 13, 2018
1b14c6c
Merge branch 'upstream' into add/image-details
Nov 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Resolve final review comment
  • Loading branch information
Ned Zimmerman committed Nov 13, 2018
commit 48dc15fe83bc0b62d4ceaee4ce75c6eb6192d6b9
2 changes: 1 addition & 1 deletion packages/block-library/src/image/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ const schema = {
children: {
...imageSchema,
a: {
attributes: [ 'linkClass', 'href', 'rel', 'target' ],
attributes: [ 'href', 'rel', 'target' ],
children: imageSchema,
},
figcaption: {
Expand Down