Add shortcode package #7581
Merged
Add shortcode package #7581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still making some doc block tweaks. |
c3b53f6
to
452cdab
Compare
|
I think this is ready for review. I don't know if we want to make any other tweaks to the shortcode code... |
aduth
approved these changes
Jun 27, 2018
| <!-- wp:gallery {"columns":3,"linkTo":"attachment"} --> | ||
| <ul class="wp-block-gallery alignnone columns-3 is-cropped"> | ||
| <li class="blocks-gallery-item"> | ||
| <figure><img data-id="1" /></figure> |
There was a problem hiding this comment.
A bit unfortunate that without the editor session to request and populate these attributes, we're effectively mangling the original content and destroying the images which would otherwise be shown by running it through the parser. Not really sure we have an option here outside of allowing transforms to be asynchronous.
452cdab
to
83fb890
Compare
|
Cool 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch adds a shortcode package to Gutenberg, instead of relying on the core global. This is needed for us to add tests for the shortcode converter (and future tweaks).
See https://github.com/WordPress/wordpress-develop/blob/master/src/js/_enqueues/wp/shortcode.js and https://github.com/WordPress/wordpress-develop/blob/master/tests/qunit/wp-includes/js/shortcode.js.
How has this been tested?
Ensure shortcode converting still works.
Screenshots
Types of changes
Checklist: