Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the button group button selector more specific #7533

Merged
merged 1 commit into from
Jul 3, 2018
Merged

Make the button group button selector more specific #7533

merged 1 commit into from
Jul 3, 2018

Conversation

chrisvanpatten
Copy link
Member

Description

Makes the button group nested button selector more specific, so the border-radius property is applied correctly. Fixes #7531.

How has this been tested?

Manually in macOS Safari and Chrome

Screenshots

Before:

untitled____add_new_page mindful _wordpress

After:

untitled___ mindful _wordpress

Types of changes

Modifies a CSS selector to be more specific, resolving an issue introduced in ce61b59

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@chrisvanpatten
Copy link
Member Author

(Travis failure seems unrelated…)

@danielbachhuber danielbachhuber requested a review from a team June 27, 2018 12:47
@danielbachhuber danielbachhuber added this to the 3.2 milestone Jun 27, 2018
@danielbachhuber danielbachhuber added the [Type] Bug An existing feature does not function as intended label Jun 27, 2018
@danielbachhuber
Copy link
Member

Travis failure is unrelated. I've restarted the job.

@aduth aduth added Needs Design Feedback Needs general design feedback. and removed Needs Design Feedback Needs general design feedback. labels Jul 3, 2018
aduth
aduth approved these changes Jul 3, 2018
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@aduth aduth merged commit e69dca4 into WordPress:master Jul 3, 2018
@chrisvanpatten chrisvanpatten deleted the fix/button-group-radius branch July 3, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisvanpatten @danielbachhuber @aduth