Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob: Extract new blob package out of utils module #6973

Merged
merged 1 commit into from
May 28, 2018
Merged

Blob: Extract new blob package out of utils module #6973

merged 1 commit into from
May 28, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 28, 2018 •
edited
Loading

Description

Related issues: #3955, #6594.
Similar: #6658, #6756, #6758, #6828.

This PR tries to provide Lerna setup similar to what we have in WordPress/packages. This would allow publishing source code of individual modules to npm to make them available for all plugin developers.

After moving date and element (and soon data), extracting dom from utils this PR extracts blob module and puts it into packages folder maintained by Lerna. This is a prerequisite for moving blocks module to npm packages structure.

How has this been tested?

Manually:

  • Removed node_modules folder.
  • npm install
  • npm test
  • npm run dev
  • npm run build
  • npm run package-plugin

Types of changes

Refactoring.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@gziolo gziolo self-assigned this May 28, 2018
@gziolo gziolo added npm Packages Related to npm packages [Type] Refactoring labels May 28, 2018
@gziolo gziolo added this to the 3.0 milestone May 28, 2018
@gziolo gziolo requested review from a team, youknowriad and ellatrix May 28, 2018 08:55
ellatrix
ellatrix approved these changes May 28, 2018
View reviewed changes
Copy link
Member

@ellatrix ellatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@gziolo gziolo merged commit bfafd1b into master May 28, 2018
@gziolo gziolo deleted the add/blob-package branch May 28, 2018 14:20
@Shelob9 Shelob9 mentioned this pull request May 29, 2018
Closed
19 tasks
@ellatrix ellatrix added [Type] Code Quality Issues or PRs that relate to code quality and removed [Type] Code Quality Issues or PRs that relate to code quality labels Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellatrix ellatrix ellatrix approved these changes

@youknowriad youknowriad Awaiting requested review from youknowriad

Assignees

@gziolo gziolo

Labels
npm Packages Related to npm packages [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gziolo @ellatrix