Restore The wp-blocks stylesheet for backwards compatibility concerns #6778
Conversation
|
Hey, this explains why the blocks in a plugin I was working on were missing their shared-by-editor-and-front-end styles... the stylesheet was not loading because Is there a replacement for this stylesheet? Actually, what did it do in the first place? |
|
@SuperGeniusZeb I don't know why we had docs requiring this as a dependency, it's useless, just remove it. These were moved to |
| array( | ||
| 'wp-blocks', | ||
| ), | ||
| array(), |
There was a problem hiding this comment.
It looks like we need to submit a patch to WP-CLI to avoid confusion ...
lib/client-assets.php
Outdated
| @@ -360,6 +360,13 @@ function gutenberg_register_scripts_and_styles() { | |||
| ); | |||
|
|
|||
| // Editor Styles. | |||
| wp_register_style( | |||
| 'wp-blocks', | |||
| gutenberg_url( 'build/blocks/style.css' ), | |||
There was a problem hiding this comment.
wp_register_style( 'wp-blocks', false ); should be enough for back-compat.
a88b2b6
to
7a873d8
Compare
|
@youknowriad wild guess it was probably added for demonstration purpose @gziolo WP-CLI Patch submitted wp-cli/scaffold-command#151 |
|
For |
|
Awesome work @ajitbohra 💯 WP-CLI patch has already landed 🎉 |
This PR restores an empty
wp-blocksstylesheet for backwards compatibility. Several docs were suggesting adding this stylesheet as a dependency.create-guten-blocksalso does so for each generated block.Question