Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip Component: Add custom class name support #63157

Merged
merged 17 commits into from
Jul 8, 2024
Merged

Tooltip Component: Add custom class name support #63157

merged 17 commits into from
Jul 8, 2024

Conversation

aliaghdam
Copy link
Contributor

@aliaghdam aliaghdam commented Jul 5, 2024 •
edited
Loading

What?

The Tooltip component does not supports custom css class name.

Why?

I added the custom class name support that that for many reasons can be used for design customization of tooltip.

How?

I added the className prop and also added test to make sure it works properly.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Unlinked contributors: aliaghdam.

@aliaghdam aliaghdam requested a review from ajitbohra as a code owner July 5, 2024 00:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: aliaghdam <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: ciampo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @aliaghdam! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@akasunil akasunil added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Jul 5, 2024
@mirka mirka requested a review from a team July 5, 2024 12:57
tyxla
tyxla reviewed Jul 5, 2024
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @aliaghdam 🙌

I've left some suggestions and questions for your consideration, let me know what you think.

packages/components/src/tooltip/index.tsx Outdated Show resolved Hide resolved
packages/components/src/tooltip/types.ts Outdated Show resolved Hide resolved
packages/components/src/tooltip/test/index.tsx Outdated Show resolved Hide resolved
packages/components/src/tooltip/test/index.tsx Outdated Show resolved Hide resolved
packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
packages/components/src/tooltip/index.tsx Outdated Show resolved Hide resolved
packages/components/src/tooltip/test/index.tsx Outdated Show resolved Hide resolved
@aliaghdam aliaghdam requested a review from tyxla July 6, 2024 08:35
tyxla
tyxla reviewed Jul 8, 2024
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the feedback @aliaghdam 🙌

The PR should be good to go once @ciampo's feedback is addressed.

packages/components/CHANGELOG.md Outdated Show resolved Hide resolved
@ciampo ciampo requested a review from tyxla July 8, 2024 11:52
@ciampo ciampo self-requested a review July 8, 2024 11:52
ciampo
ciampo approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Thank you for your work!

@ciampo ciampo merged commit e9fd507 into WordPress:trunk Jul 8, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 18.8 milestone Jul 8, 2024
huubl pushed a commit to huubl/gutenberg that referenced this pull request Jul 10, 2024
@aliaghdam @tyxla
@ciampo @huubl
Tooltip Component: Add custom class name support (WordPress#63157)
97e1cf2 
* feat: custom class name support for Tooltip component

* test: add custom class name tests for Tooltip component

* chore: changelog update

* chore: improve comment

* chore: fix string literals

Co-authored-by: Marin Atanasov <[email protected]>

* fix: use clx for classname

Co-authored-by: Marin Atanasov <[email protected]>

* fix: changelog

Co-authored-by: Marin Atanasov <[email protected]>

* fix: merge tests

Co-authored-by: Marin Atanasov <[email protected]>

* fix: import clx

* fix: props order

* chore: improve test name

* fix: changelog

* chore: props order

* chore: remove empty line

Co-authored-by: Marin Atanasov <[email protected]>

* chore: remove internal class name from prop description.

Co-authored-by: Marco Ciampini <[email protected]>

---------

Co-authored-by: aliaghdam <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: ciampo <[email protected]>
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jul 18, 2024
@aliaghdam @tyxla
@ciampo @carstingaxion
Tooltip Component: Add custom class name support (WordPress#63157)
149825d 
* feat: custom class name support for Tooltip component

* test: add custom class name tests for Tooltip component

* chore: changelog update

* chore: improve comment

* chore: fix string literals

Co-authored-by: Marin Atanasov <[email protected]>

* fix: use clx for classname

Co-authored-by: Marin Atanasov <[email protected]>

* fix: changelog

Co-authored-by: Marin Atanasov <[email protected]>

* fix: merge tests

Co-authored-by: Marin Atanasov <[email protected]>

* fix: import clx

* fix: props order

* chore: improve test name

* fix: changelog

* chore: props order

* chore: remove empty line

Co-authored-by: Marin Atanasov <[email protected]>

* chore: remove internal class name from prop description.

Co-authored-by: Marco Ciampini <[email protected]>

---------

Co-authored-by: aliaghdam <[email protected]>
Co-authored-by: tyxla <[email protected]>
Co-authored-by: ciampo <[email protected]>
lipemat added a commit to lipemat/types-js-boilerplate that referenced this pull request Aug 21, 2024
@lipemat
Add className property to ToolTip
e473b30 
WordPress/gutenberg#63157
@fabiankaegy fabiankaegy added the Needs Dev Note Requires a developer note for a major WordPress release cycle label Oct 1, 2024
@fabiankaegy fabiankaegy mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciampo ciampo ciampo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@tyxla tyxla Awaiting requested review from tyxla

Assignees

@aliaghdam aliaghdam

Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Enhancement A suggestion for improvement.
Projects
WordPress 6.7 Documentation
Status: Todo
Milestone
Gutenberg 18.8
Development

Successfully merging this pull request may close these issues.
5 participants
@aliaghdam @ciampo @tyxla @fabiankaegy @akasunil