Fix Markdown paste containing HTML #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
approved these changes
Apr 20, 2018
blocks/api/raw-handling/index.js
Outdated
| @@ -54,7 +54,7 @@ export default function rawHandler( { HTML, plainText = '', mode = 'AUTO', tagNa | |||
| // Parse Markdown (and HTML) if: | |||
| // * There is a plain text version. | |||
| // * The HTML version has no formatting. | |||
| if ( plainText && isPlain( HTML ) ) { | |||
| if ( plainText && ( ! HTML || isPlain( HTML ) ) ) { | |||
There was a problem hiding this comment.
The comment above needs updating.
|
Thanks for the quick review, @mcsf! |
nuzzio
pushed a commit
to nuzzio/gutenberg
that referenced
this pull request
Apr 25, 2018
* Fix Markdown paste containing HTML * Add test case * Update comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch fixes the following issue: when pasting Markdown that contains any (unencoded) HTML,
isPlain( HTML )will stumble upon the tag and return false, skipping Markdown parsing and pasting the content inline. The solution here is to not pass any HTML at all to therawHandlerwhen no HTML has been pasted.How has this been tested?
Paste any Markdown that contains HTML tags (which is valid Markdown). On the master branch this will not paste nicely (inline). On this branch the Markdown should be parsed and blocks should be inserted.
Checklist: